-
Notifications
You must be signed in to change notification settings - Fork 124
[cts] Add adapters ignore lists for conformance tests #823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# Conformance tests | ||
|
||
lukaszstolarczuk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
At this point, conformance tests include matches for individual adapters | ||
that allow you to ignore errors from the listed tests. | ||
This solution allows regular execution of cts tests on GHA | ||
and prevents further errors. | ||
In the future, when all bugs are fixed, and the tests pass, | ||
this solution will no longer be necessary. | ||
When you fix any test, the match file must be updated | ||
Empty match files indicate that there are no failing tests | ||
in a particular group for the corresponding adapter. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
urContextCreateWithNativeHandleTest.Success/NVIDIA_CUDA_BACKEND___{{.*}}_ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
urContextCreateWithNativeHandleTest.Success/AMD_HIP_BACKEND___{{.*}}_ | ||
urContextSetExtendedDeleterTest.Success/AMD_HIP_BACKEND___{{.*}}_ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
urContextCreateWithNativeHandleTest.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}_ | ||
urContextGetInfoTestWithInfoParam.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UR_CONTEXT_INFO_USM_MEMCPY2D_SUPPORT | ||
urContextGetInfoTestWithInfoParam.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UR_CONTEXT_INFO_USM_FILL2D_SUPPORT | ||
urContextSetExtendedDeleterTest.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}_ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
#! /usr/bin/env python3 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For now it's fine, but eventually, I'd like to see this script somehow merged with #810. They fulfill a similar role... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, we can plan such changes in the future. |
||
""" | ||
Copyright (C) 2023 Intel Corporation | ||
|
||
Part of the Unified-Runtime Project, under the Apache License v2.0 with LLVM Exceptions. | ||
See LICENSE.TXT | ||
SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
||
""" | ||
|
||
import sys | ||
from argparse import ArgumentParser | ||
import subprocess # nosec B404 | ||
import signal | ||
import re | ||
|
||
if __name__ == '__main__': | ||
|
||
parser = ArgumentParser() | ||
parser.add_argument("--test_command", help="Ctest test case") | ||
|
||
args = parser.parse_args() | ||
result = subprocess.Popen([args.test_command, '--gtest_brief=1'], stdout = subprocess.PIPE, text = True) # nosec B603 | ||
pbalcer marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
pat = re.compile(r'\[( )*FAILED( )*\]') | ||
for line in result.stdout.readlines(): | ||
if pat.search(line): | ||
test_case = line.split(" ")[5] | ||
test_case = test_case.rstrip(',') | ||
print(test_case) | ||
|
||
result.communicate() | ||
rc = result.returncode | ||
if rc < 0: | ||
print(signal.strsignal(abs(result.returncode))) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
urDeviceGetTest.InvalidValueNumEntries | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_SUPPORTED_PARTITIONS | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_PARTITION_TYPE | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_VIRTUAL_MEMORY_SUPPORT |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
{{OPT}}urDeviceCreateWithNativeHandleTest.Success | ||
{{OPT}}urDeviceGetTest.InvalidValueNumEntries | ||
{{OPT}}urDeviceGetGlobalTimestampTest.Success | ||
{{OPT}}urDeviceGetGlobalTimestampTest.SuccessSynchronizedTime | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_SINGLE_FP_CONFIG | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_DOUBLE_FP_CONFIG | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_QUEUE_PROPERTIES | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_IMAGE_SUPPORTED | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_MAX_READ_WRITE_IMAGE_ARGS | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_QUEUE_ON_DEVICE_PROPERTIES | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_QUEUE_ON_HOST_PROPERTIES | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_IL_VERSION | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_SUPPORTED_PARTITIONS | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_PARTITION_TYPE | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_GPU_EU_COUNT | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_GPU_EU_SIMD_WIDTH | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_GPU_EU_SLICES | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_GPU_EU_COUNT_PER_SUBSLICE | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_GPU_SUBSLICES_PER_SLICE | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_GPU_HW_THREADS_PER_EU | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_MAX_MEMORY_BANDWIDTH | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_ATOMIC_MEMORY_ORDER_CAPABILITIES | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_BFLOAT16 | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_ASYNC_BARRIER | ||
{{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_VIRTUAL_MEMORY_SUPPORT |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
urDeviceGetTest.InvalidValueNumEntries | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_IMAGE_SUPPORTED | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_GLOBAL_MEM_FREE | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_ERROR_CORRECTION_SUPPORT | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_HOST_UNIFIED_MEMORY | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_ENDIAN_LITTLE | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_AVAILABLE | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_COMPILER_AVAILABLE | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_LINKER_AVAILABLE | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_PREFERRED_INTEROP_USER_SYNC | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_SUPPORTED_PARTITIONS | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_PARTITION_TYPE | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_SUB_GROUP_INDEPENDENT_FORWARD_PROGRESS | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_MAX_MEMORY_BANDWIDTH | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_IMAGE_SRGB | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_BUILD_ON_SUBDEVICE | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_ATOMIC_64 | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_ASYNC_BARRIER | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_MEM_CHANNEL_SUPPORT | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_HOST_PIPE_READ_WRITE_SUPPORTED | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_MAX_REGISTERS_PER_WORK_GROUP | ||
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_VIRTUAL_MEMORY_SUPPORT |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Segmentation fault |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Segmentation fault |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Segmentation fault |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{{Segmentation fault|Aborted}} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
urEventCreateWithNativeHandleTest.Success/AMD_HIP_BACKEND___{{.*}}_ | ||
urEventSetCallbackTest.Success/AMD_HIP_BACKEND___{{.*}}_ | ||
urEventSetCallbackTest.ValidateParameters/AMD_HIP_BACKEND___{{.*}}_ | ||
urEventSetCallbackTest.AllStates/AMD_HIP_BACKEND___{{.*}}_ | ||
urEventSetCallbackTest.EventAlreadyCompleted/AMD_HIP_BACKEND___{{.*}}_ | ||
urEventSetCallbackNegativeTest.InvalidNullHandle/AMD_HIP_BACKEND___{{.*}}_ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{{OPT}}urEventGetInfoTest.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UR_EVENT_INFO_COMMAND_TYPE | ||
{{OPT}}urEventGetProfilingInfoTest.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UR_PROFILING_INFO_COMMAND_QUEUED | ||
{{OPT}}urEventGetProfilingInfoTest.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UR_PROFILING_INFO_COMMAND_SUBMIT | ||
{{OPT}} Segmentation fault |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Segmentation fault |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Segmentation fault |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Segmentation fault |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
urMemBufferCreateWithNativeHandleTest.Success/NVIDIA_CUDA_BACKEND___{{.*}}_ | ||
urMemGetInfoTest.InvalidNullPointerParamValue/NVIDIA_CUDA_BACKEND___{{.*}}___UR_MEM_INFO_SIZE | ||
urMemGetInfoTest.InvalidNullPointerParamValue/NVIDIA_CUDA_BACKEND___{{.*}}___UR_MEM_INFO_CONTEXT | ||
urMemGetInfoTest.InvalidNullPointerPropSizeRet/NVIDIA_CUDA_BACKEND___{{.*}}___UR_MEM_INFO_SIZE | ||
urMemGetInfoTest.InvalidNullPointerPropSizeRet/NVIDIA_CUDA_BACKEND___{{.*}}___UR_MEM_INFO_CONTEXT | ||
{{OPT}}urMemImageGetInfoTest.Success/NVIDIA_CUDA_BACKEND___{{.*}}___UR_IMAGE_INFO_FORMAT | ||
{{OPT}}urMemImageGetInfoTest.Success/NVIDIA_CUDA_BACKEND___{{.*}}___UR_IMAGE_INFO_ELEMENT_SIZE | ||
{{OPT}}urMemImageGetInfoTest.Success/NVIDIA_CUDA_BACKEND___{{.*}}___UR_IMAGE_INFO_ROW_PITCH | ||
{{OPT}}urMemImageGetInfoTest.Success/NVIDIA_CUDA_BACKEND___{{.*}}___UR_IMAGE_INFO_SLICE_PITCH | ||
{{OPT}}urMemImageGetInfoTest.Success/NVIDIA_CUDA_BACKEND___{{.*}}___UR_IMAGE_INFO_WIDTH | ||
{{OPT}}urMemImageGetInfoTest.Success/NVIDIA_CUDA_BACKEND___{{.*}}___UR_IMAGE_INFO_HEIGHT | ||
{{OPT}}urMemImageGetInfoTest.Success/NVIDIA_CUDA_BACKEND___{{.*}}___UR_IMAGE_INFO_DEPTH | ||
{{OPT}}urMemImageGetInfoTest.InvalidSizeSmall/NVIDIA_CUDA_BACKEND___{{.*}}___UR_IMAGE_INFO_FORMAT | ||
{{OPT}}urMemImageGetInfoTest.InvalidSizeSmall/NVIDIA_CUDA_BACKEND___{{.*}}___UR_IMAGE_INFO_ELEMENT_SIZE | ||
{{OPT}}urMemImageGetInfoTest.InvalidSizeSmall/NVIDIA_CUDA_BACKEND___{{.*}}___UR_IMAGE_INFO_ROW_PITCH | ||
{{OPT}}urMemImageGetInfoTest.InvalidSizeSmall/NVIDIA_CUDA_BACKEND___{{.*}}___UR_IMAGE_INFO_SLICE_PITCH | ||
{{OPT}}urMemImageGetInfoTest.InvalidSizeSmall/NVIDIA_CUDA_BACKEND___{{.*}}___UR_IMAGE_INFO_WIDTH | ||
{{OPT}}urMemImageGetInfoTest.InvalidSizeSmall/NVIDIA_CUDA_BACKEND___{{.*}}___UR_IMAGE_INFO_HEIGHT | ||
{{OPT}}urMemImageGetInfoTest.InvalidSizeSmall/NVIDIA_CUDA_BACKEND___{{.*}}___UR_IMAGE_INFO_DEPTH |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
urMemBufferCreateWithNativeHandleTest.Success/AMD_HIP_BACKEND___{{.*}}_ | ||
Segmentation fault |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
urMemBufferCreateTest.InvalidBufferSizeZero/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}_ | ||
urMemBufferPartitionTest.InvalidBufferSize/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}_ | ||
urMemBufferPartitionTest.InvalidValueCreateType/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}_ | ||
urMemBufferPartitionTest.InvalidValueBufferCreateInfoOutOfBounds/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}_ | ||
urMemGetInfoTest.InvalidNullPointerParamValue/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UR_MEM_INFO_SIZE | ||
urMemGetInfoTest.InvalidNullPointerParamValue/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UR_MEM_INFO_CONTEXT | ||
urMemGetInfoTest.InvalidNullPointerPropSizeRet/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UR_MEM_INFO_SIZE | ||
urMemGetInfoTest.InvalidNullPointerPropSizeRet/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UR_MEM_INFO_CONTEXT | ||
Segmentation fault |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
urPlatformGetNativeHandleTest.Success | ||
urPlatformGetNativeHandleTest.InvalidNullHandlePlatform | ||
urPlatformGetNativeHandleTest.InvalidNullPointerNativePlatform |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
urPlatformGetTest.InvalidNumEntries | ||
urPlatformGetNativeHandleTest.Success | ||
urPlatformGetNativeHandleTest.InvalidNullHandlePlatform | ||
urPlatformGetNativeHandleTest.InvalidNullPointerNativePlatform |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Segmentation fault |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Segmentation fault |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Segmentation fault |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
urQueueCreateTest.InvalidValueProperties/NVIDIA_CUDA_BACKEND___{{.*}}_ | ||
urQueueCreateTest.InvalidQueueProperties/NVIDIA_CUDA_BACKEND___{{.*}}_ | ||
urQueueCreateWithNativeHandleTest.Success/NVIDIA_CUDA_BACKEND___{{.*}}_ | ||
urQueueGetInfoTestWithInfoParam.Success/NVIDIA_CUDA_BACKEND___{{.*}}___UR_QUEUE_INFO_DEVICE_DEFAULT | ||
urQueueGetInfoTestWithInfoParam.Success/NVIDIA_CUDA_BACKEND___{{.*}}___UR_QUEUE_INFO_SIZE |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
urQueueCreateTest.InvalidValueProperties/AMD_HIP_BACKEND___{{.*}}_ | ||
urQueueCreateTest.InvalidQueueProperties/AMD_HIP_BACKEND___{{.*}}_ | ||
urQueueCreateWithParamTest.SuccessWithProperties/AMD_HIP_BACKEND___{{.*}}___UR_QUEUE_FLAG_OUT_OF_ORDER_EXEC_MODE_ENABLE | ||
urQueueCreateWithParamTest.SuccessWithProperties/AMD_HIP_BACKEND___{{.*}}___UR_QUEUE_FLAG_PROFILING_ENABLE | ||
urQueueCreateWithNativeHandleTest.Success/AMD_HIP_BACKEND___{{.*}}_ | ||
urQueueGetInfoTestWithInfoParam.Success/AMD_HIP_BACKEND___{{.*}}___UR_QUEUE_INFO_DEVICE_DEFAULT | ||
urQueueGetInfoTestWithInfoParam.Success/AMD_HIP_BACKEND___{{.*}}___UR_QUEUE_INFO_SIZE |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
urQueueCreateTest.InvalidValueProperties/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}_ | ||
urQueueCreateTest.InvalidQueueProperties/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}_ | ||
{{Segmentation fault|Aborted}} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
urAdapterGetLastErrorTest.Success |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
urSamplerGetNativeHandleTest.Success/NVIDIA_CUDA_BACKEND___{{.*}}_ | ||
urSamplerGetNativeHandleTest.InvalidNullHandleSampler/NVIDIA_CUDA_BACKEND___{{.*}}_ | ||
urSamplerGetNativeHandleTest.InvalidNullPointerNativeHandle/NVIDIA_CUDA_BACKEND___{{.*}}_ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
urSamplerGetNativeHandleTest.Success/AMD_HIP_BACKEND___{{.*}}_ | ||
urSamplerGetNativeHandleTest.InvalidNullHandleSampler/AMD_HIP_BACKEND___{{.*}}_ | ||
urSamplerGetNativeHandleTest.InvalidNullPointerNativeHandle/AMD_HIP_BACKEND___{{.*}}_ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
urSamplerGetInfoTestWithParam.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UR_SAMPLER_INFO_REFERENCE_COUNT | ||
urSamplerGetInfoTestWithParam.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UR_SAMPLER_INFO_CONTEXT | ||
urSamplerGetInfoTestWithParam.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UR_SAMPLER_INFO_NORMALIZED_COORDS | ||
urSamplerGetInfoTestWithParam.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UR_SAMPLER_INFO_ADDRESSING_MODE | ||
urSamplerGetInfoTestWithParam.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UR_SAMPLER_INFO_FILTER_MODE | ||
urSamplerGetInfoTest.InvalidSizePropSizeSmall/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}_ | ||
urSamplerReleaseTest.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}_ | ||
urSamplerRetainTest.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand, this makes optional lines hard to check for - they can contain literally anything and the test can pass. Can we make opt lines required given a certain test scenario or setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would require us to somehow make the lines "conditional", so something like
{{skip if compiler==clang}}
. While that might be useful, it's imho out of scope for this work. And no, optional lines can't be anything - thiscontinue
here will only move forward the match file, not the input file, so if the line doesn't match either the optional line or the next one, it will fail.