Skip to content

Conversation

veselypeta
Copy link
Contributor

@veselypeta veselypeta commented Aug 23, 2023

Define a specific conformance test macro which will fail each test that exits with a crash intead of failing the entire test suite.

If we decide to use this macro, we will need to ensure that we run the testsuites with the --gtest_death_test_style=threadsafe

@pbalcer
Copy link
Contributor

pbalcer commented Aug 25, 2023

That looks clunky, but I guess it's out of the way for the most part...

Maybe it would be simpler to run tests one by one? We are already going to be wrapping test execution in a script (#823), so might as well do a loop inside of it. I'm not sure what's better.

@kbenzie
Copy link
Contributor

kbenzie commented Aug 25, 2023

Maybe it would be simpler to run tests one by one?

In my experience with UnitCL this ends up being much slower to run. If we do decide to do that though, there is a ready made tool for it gtest-parallel.

@kbenzie
Copy link
Contributor

kbenzie commented Aug 25, 2023

Long term we do expect there to be no crashes in the CTS so I feel like this approach is very heavy handed way of dealing with the problem at hand. This gtest functionality is not intended to be used on every single test case but rather to test specific failure modes around process exits.

@veselypeta veselypeta closed this Aug 28, 2023
@veselypeta
Copy link
Contributor Author

Dropping this solution in favour of #810

@veselypeta veselypeta deleted the petr/conformance-test-macro branch October 26, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants