Skip to content

Conversation

kbenzie
Copy link
Contributor

@kbenzie kbenzie commented Jul 17, 2025

Automated changes by create-pull-request GitHub action

martygrant and others added 9 commits July 17, 2025 00:43
…class (#19387)

For intel/llvm#18644

Most UR adapters had their own reference counting of some sort. This
adds a new RefCount class and refactors adapter code so all adapters can
share the same code for reference counting. This PR handles HIP.

I have kept the pre-existing reference counting members inside
stream_queue.hpp, temporarily renaming it as RefCountOld as the CUDA
adapter also uses this and want to only change one adapter per PR. I
will revert this once the last of the HIP and CUDA PRs are merged.
Unless something has gone terribly wrong, the compiler used to compile
cpp files will be a cpp compiler.
… class (#19287)

For intel/llvm#18644

Most UR adapters had their own reference counting of some sort. This
adds a new RefCount class and refactors adapter code so all adapters can
share the same code for reference counting. This PR handles CUDA and I
will open more PRs for each adapter in turn.

I have kept the pre-existing reference counting members inside
`stream_queue.hpp`, temporarily renaming it as `RefCountOld` as the HIP
adapter also uses this and want to only change one adapter per PR. I
will revert this once the last of the HIP and CUDA PRs are merged.
Support pool query via urUSMPoolGetInfoExp for information about
reserved or in-use memory and their peak sizes.
* Previously we only clean shadow once, this may cause false positive
reports sometimes. So, we need to clean shadow of allocated memory
before each kernel launch.
* Allow internal managed queue to be created with out of order property
for better performance.
* Updated one test for better code coverage.
The current implementation unnecessarily cleans up the freelist when
enqueueing new USM allocations. This creates a potential scenario where
active allocations present in the freelist could be incorrectly freed.
The change making L0 v2 adapter default for BMG broke handling of
UR_ADAPTERS_FORCE_LOAD. Depending on the platform, urAdapterGet could
return 0 available adapter even if force loadded.
@kbenzie kbenzie requested a review from a team as a code owner July 17, 2025 00:43
Copy link
Contributor

Unified Runtime -> intel/llvm Repo Move Notice

Information

The source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory,
all future development will now be carried out there. This was done in intel/llvm#17043.

The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime.

The contribution guide will be updated with new instructions for contributing to Unified Runtime.

PR Migration

All open PRs including this one will be marked with the auto-close label and shall be automatically closed after 30 days.

Should you wish to continue with your PR you will need to migrate it to intel/llvm.
We have provided a script to help automate this process.

If your PR should remain open and not be closed automatically, you can remove the auto-close label.


This is an automated comment.

@kbenzie kbenzie merged commit 52f8b78 into main Jul 17, 2025
@kbenzie kbenzie deleted the mirror-commits- branch July 17, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants