Skip to content

[DeviceMSAN] Fix gpu crashed on device global variable #2534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 15, 2025
Merged

[DeviceMSAN] Fix gpu crashed on device global variable #2534

merged 8 commits into from
Jan 15, 2025

Conversation

@AllanZyne
Copy link
Contributor

@AllanZyne AllanZyne commented Jan 9, 2025 •
edited
Loading

@AllanZyne AllanZyne requested a review from a team as a code owner January 9, 2025 06:10
@AllanZyne AllanZyne mentioned this pull request Jan 9, 2025
Merged
@github-actions github-actions bot added the loader Loader related feature/bug label Jan 9, 2025
@zhaomaosu @AllanZyne
Record usm allocated size
f1e4711 
(cherry picked from commit 5c5e9b9)
@AllanZyne
Copy link
Contributor Author

AllanZyne commented Jan 13, 2025 •
edited
Loading

Hi @oneapi-src/unified-runtime-maintain, please add this into 2025.1, thanks!

@AllanZyne AllanZyne requested a review from zhaomaosu January 13, 2025 06:33
zhaomaosu
zhaomaosu approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@zhaomaosu zhaomaosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kbenzie kbenzie added the v0.11.x Include in the v0.11.x release label Jan 13, 2025
@AllanZyne
Copy link
Contributor Author

AllanZyne commented Jan 14, 2025

@oneapi-src/unified-runtime-maintain, please review, thanks

@pbalcer pbalcer added the ready to merge Added to PR's which are ready to merge label Jan 14, 2025
@AllanZyne
Copy link
Contributor Author

AllanZyne commented Jan 14, 2025

Pushed a small change

@kbenzie kbenzie merged commit 6a3fece into oneapi-src:main Jan 15, 2025
73 checks passed
sarnex pushed a commit to intel/llvm that referenced this pull request Jan 15, 2025
@AllanZyne @kbenzie
[DeviceMSAN] Fix gpu crashed on device global variable (#16566)
ec8346e 
UR: oneapi-src/unified-runtime#2534

---------

Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
kbenzie added a commit that referenced this pull request Jan 17, 2025
@kbenzie
Merge pull request #2534 from AllanZyne/review/yang/msan_device_global
ffb83cc 
[DeviceMSAN] Fix gpu crashed on device global variable
@kbenzie kbenzie mentioned this pull request Jan 17, 2025
Merged
@AllanZyne AllanZyne deleted the review/yang/msan_device_global branch January 20, 2025 00:37
KornevNikita pushed a commit to intel/llvm that referenced this pull request Feb 25, 2025
@AllanZyne @kbenzie @KornevNikita
[DeviceMSAN] Fix gpu crashed on device global variable (#16566)
bb7eca4 
UR: oneapi-src/unified-runtime#2534

---------

Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbalcer pbalcer pbalcer approved these changes

+2 more reviewers

@zhaomaosu zhaomaosu zhaomaosu approved these changes

@yingcong-wu yingcong-wu yingcong-wu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

loader Loader related feature/bug ready to merge Added to PR's which are ready to merge v0.11.x Include in the v0.11.x release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AllanZyne @pbalcer @zhaomaosu @yingcong-wu @kbenzie