Move urMemoryGetInfo success test from a switch to individual tests #2521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
martygrant
force-pushed
the
martin/memory-info-unswitch
branch
3 times, most recently
from
b5197f8 to
19031ed
Compare
RossBrunton
reviewed
Jan 8, 2025
kbenzie
approved these changes
Jan 8, 2025
Reworked urAdapterGetInfo - ValidAdapterBackend test was redundant. Also tidy up some other urXGetInfo tests with default values and removing unneccessary casts.
martygrant
force-pushed
the
martin/memory-info-unswitch
branch
from
19031ed to
2ce90d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2290
Also reworked urAdapterGetInfo - ValidAdapterBackend test was redundant.
Also tidy up some other urXGetInfo tests with default values and removing unneccessary casts.