[L0] Fixed getImmCmdList returning cmdlist with wrong properties #2429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winstonzhang-intel
added a commit
to winstonzhang-intel/llvm
that referenced
this pull request
Dec 5, 2024
oneapi-src/unified-runtime#2429 Signed-off-by: Zhang, Winston <[email protected]>
nrspruit
approved these changes
Dec 5, 2024
Contributor
nrspruit
left a comment
nrspruit
left a comment
There was a problem hiding this comment.
LGTM, thanks for the patch!
When using counterbased events, sometimes when retrieving commandlist, in getImmCmdlist we return a cmdlist that is not in order. Signed-off-by: Zhang, Winston <[email protected]>
winstonzhang-intel
force-pushed
the
urlza428
branch
from
a1d31bb to
dbf1b70
Compare
igchor
approved these changes
Dec 6, 2024
nrspruit
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using counterbased events, sometimes when retrieving immediate commandlist, we would return a commandlist that is does not have the ZE_COMMAND_QUEUE_FLAG_IN_ORDER flag set which causes an invalid argument when trying to use that commandlist later.
SYCL/LLVM: intel/llvm#16291