-
Notifications
You must be signed in to change notification settings - Fork 124
[DevAsan] Report error when using unsupported extension API #2420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kbenzie
merged 1 commit into
oneapi-src:main
from
yingcong-wu:yc-PR/1204-error-on-unsupported-feature
Dec 10, 2024
Merged
[DevAsan] Report error when using unsupported extension API #2420
kbenzie
merged 1 commit into
oneapi-src:main
from
yingcong-wu:yc-PR/1204-error-on-unsupported-feature
Dec 10, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZyne
approved these changes
Dec 10, 2024
Contributor
AllanZyne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
zhaomaosu
reviewed
Dec 10, 2024
pbalcer
reviewed
Dec 10, 2024
pbalcer
approved these changes
Dec 10, 2024
Some extensions are not currently supported by device address sanitizer. We may add support for those later, but for now, we will report errors when using unsupported API to let users know instead of failing for other random errors and puzzling the users.
a9387f3 to
b532350
Compare
sommerlukas
pushed a commit
to intel/llvm
that referenced
this pull request
Dec 11, 2024
UR PR: oneapi-src/unified-runtime#2420 --------- Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
loader
Loader related feature/bug
ready to merge
Added to PR's which are ready to merge
v0.11.x
Include in the v0.11.x release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some extensions are not currently supported by device address sanitizer. We may add support for those later, but for now, we will report errors when using unsupported API to let users know instead of failing for other random errors and puzzling the users.
Intel/llvm PR: intel/llvm#16281