Skip to content

Conversation

@zhaomaosu
Copy link
Contributor

@zhaomaosu zhaomaosu commented Nov 28, 2024

Release mapped physical memory according to its dependency may cause
some problems. So, we decide to use USM pool to do allocation to
reduce memory overhead.

intel/llvm: intel/llvm#16280

@zhaomaosu zhaomaosu requested a review from a team as a code owner November 28, 2024 02:18
@github-actions github-actions bot added the loader Loader related feature/bug label Nov 28, 2024
@aarongreig
Copy link
Contributor

It might be worth considering that this will raise the bar to entry for supporting dev asan on different platforms in the future, the native_cpu and opencl adapters don't currently have usm pool support and I don't know of any plans to implement it in the near future.

If that is a concern I suggest a fallback path if pooling isn't supported, if it isn't feel free to ignore.

@zhaomaosu
Copy link
Contributor Author

It might be worth considering that this will raise the bar to entry for supporting dev asan on different platforms in the future, the native_cpu and opencl adapters don't currently have usm pool support and I don't know of any plans to implement it in the near future.

If that is a concern I suggest a fallback path if pooling isn't supported, if it isn't feel free to ignore.

Thanks for your suggestion. But original goal of this PR is to reduce memory overhead on L0 GPU device, opencl adapter doesn't support usm pool is ok for us now.

@AllanZyne
Copy link
Contributor

Hi, I have a patch on syclos which needs this PR to merge, so I update my UR tag to this one.
Feel free to link them together.

LLVM: intel/llvm#16279

@zhaomaosu
Copy link
Contributor Author

Hi @oneapi-src/unified-runtime-maintain, could you please help review this PR? We need this PR in v0.11.x, thanks.

@pbalcer pbalcer added the v0.11.x Include in the v0.11.x release label Dec 10, 2024
Release mapped physical memory according to its dependency may cause
some problems. So, we decide to use USM pool to do allocation to
reduce memory overhead.
@kbenzie kbenzie merged commit e1cc9b2 into oneapi-src:main Dec 10, 2024
13 checks passed
sarnex pushed a commit to intel/llvm that referenced this pull request Dec 10, 2024
KornevNikita pushed a commit to intel/llvm that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

loader Loader related feature/bug v0.11.x Include in the v0.11.x release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants