Fix "use after release" issues #2368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
RossBrunton
force-pushed
the
ross/release
branch
2 times, most recently
from
cfe787d to
a07352d
Compare
martygrant
reviewed
Nov 27, 2024
RossBrunton
force-pushed
the
ross/release
branch
from
a07352d to
51cbddb
Compare
RossBrunton
force-pushed
the
ross/release
branch
from
51cbddb to
f7c34e3
Compare
kbenzie
reviewed
Nov 29, 2024
kbenzie
approved these changes
Dec 2, 2024
In some cases, we use handles after releasing them, or incorrectly release handles we shouldn't. This doesn't cause any issues currently, but will when we start using reference counting in the loader.
RossBrunton
force-pushed
the
ross/release
branch
from
f7c34e3 to
8412c8b
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Dec 3, 2024
Pre-commit MR for: oneapi-src/unified-runtime#2368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, we use handles after releasing them, or incorrectly
release handles we shouldn't. This doesn't cause any issues currently,
but will when we start using reference counting in the loader.