Skip to content

Revert #2100 "Raise MSVC warning level from /W3 to /W4" #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2024
Merged

Revert #2100 "Raise MSVC warning level from /W3 to /W4" #2302

merged 1 commit into from
Nov 8, 2024

Conversation

@callumfare
Copy link
Contributor

@callumfare callumfare commented Nov 8, 2024 •
edited by kbenzie
Loading

This reverts commit 8e56347 from #2100.

This unexpectedly caused the check-sycl target to fail on Windows despite previously passing CI

@github-actions github-actions bot added loader Loader related feature/bug common Changes or additions to common utilities conformance Conformance test suite issues. images UR images specification Changes or additions to the specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Nov 8, 2024
@callumfare callumfare mentioned this pull request Nov 8, 2024
Merged
@callumfare callumfare force-pushed the callum/revert_ur_2100 branch from de8aea1 to 5bc8c92 Compare November 8, 2024 16:45
@callumfare callumfare marked this pull request as ready for review November 8, 2024 16:49
@callumfare callumfare requested review from a team as code owners November 8, 2024 16:49
@callumfare callumfare requested a review from ldrumm November 8, 2024 16:49
@callumfare callumfare merged commit c94dbc8 into oneapi-src:main Nov 8, 2024
71 of 77 checks passed
@callumfare callumfare mentioned this pull request Nov 8, 2024
Open
martygrant pushed a commit to intel/llvm that referenced this pull request Nov 11, 2024
@callumfare
[UR] Bump UR tag to c94dbc8 (#16033)
f215f43 
Pulls in oneapi-src/unified-runtime#2302
kbenzie added a commit to kbenzie/unified-runtime that referenced this pull request Nov 18, 2024
@kbenzie
Revert "Merge pull request oneapi-src#2302 from callumfare/callum/rev…
e73da20 
…ert_ur_2100"

This reverts commit c94dbc8, reversing
changes made to 9ae8e65.
kbenzie added a commit to kbenzie/unified-runtime that referenced this pull request Nov 20, 2024
@kbenzie
Raise MSVC warning level from /W3 to /W4
e214245 
This reinstates the reverted changes in oneapi-src#2100 which were reverted
in oneapi-src#2302 due to regressions in intel/llvm testing.
@kbenzie kbenzie mentioned this pull request Nov 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldrumm ldrumm Awaiting requested review from ldrumm ldrumm was automatically assigned from oneapi-src/unified-runtime-cuda-write

1 more reviewer

@kbenzie kbenzie kbenzie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

command-buffer Command Buffer feature addition/changes/specification common Changes or additions to common utilities conformance Conformance test suite issues. cuda CUDA adapter specific issues images UR images level-zero L0 adapter specific issues loader Loader related feature/bug specification Changes or additions to the specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@callumfare @kbenzie