[L0] Enable Sysman Thru Env by default and have zesInit be optional #2242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2024
nrspruit
force-pushed
the
sysman_env_disable
branch
from
8dc760b to
9029f2e
Compare
nrspruit
changed the title
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Oct 25, 2024
-pre-commit PR for oneapi-src/unified-runtime#2242 Signed-off-by: Neil R. Spruit <[email protected]>
rwmcguir
reviewed
Oct 25, 2024
nrspruit
force-pushed
the
sysman_env_disable
branch
from
9029f2e to
03dc51e
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Oct 25, 2024
-pre-commit PR for oneapi-src/unified-runtime#2242 Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
added a commit
to intel/llvm
that referenced
this pull request
Oct 25, 2024
-pre-commit PR for oneapi-src/unified-runtime#2242 Signed-off-by: Neil R. Spruit <[email protected]>
- Enable ZES_ENABLE_SYSMAN=1 by default unless UR_L0_ENABLE_SYSMAN_ENV_DEFAULT==0. - Allows for Sysman support thru zeInit() without user input. - Added UR_L0_ENABLE_ZESINIT_DEFAULT to allow for a customer to enable zesInit over sysman env init if the env allows it. - NOTE: UR_L0_ENABLE_ZESINIT_DEFAULT=1 requires UR_L0_ENABLE_SYSMAN_ENV_DEFAULT==0 due to the env overwriting the zesInit support. Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
sysman_env_disable
branch
from
03dc51e to
27ad3f7
Compare
aravindksg
approved these changes
Oct 26, 2024
kbenzie
reviewed
Oct 28, 2024
Comment on lines
+154
to
+173
| | Environment Variable | Value | Behavior | | ||
| |--------------------------------|-------|----------------------------| | ||
| | UR_L0_ENABLE_SYSMAN_ENV_DEFAULT| 1 | Enables the default SysMan | | ||
| | | | environment initialization | | ||
| | | | by setting | | ||
| | | | `ZES_ENABLE_SYSMAN` to "1".| | ||
| | | 0 | Disables the default SysMan| | ||
| | | | environment initialization.| | ||
| | | unset | Defaults to 1, enabling the| | ||
| | | | SysMan environment | | ||
| | | | initialization. | | ||
| | UR_L0_ENABLE_ZESINIT_DEFAULT | 1 | Enables the default SysMan | | ||
| | | | initialization by loading | | ||
| | | | SysMan-related functions | | ||
| | | | and calling `zesInit`. | | ||
| | | 0 | Disables the default SysMan| | ||
| | | | initialization with zesInit| | ||
| | | unset | Defaults to 0, disabling | | ||
| | | | the SysMan initialization | | ||
| | | | thru zesInit. | |
There was a problem hiding this comment.
I feel like these should be described in the env var docs but I don't see any of the other L0 adapter env vars their either.
I think the best place for these would be an L0 reference doc, similar to the CUDA ref doc and HIP ref doc describing all the L0 adapter specific env vars. This could be done in a separate PR, though.
There was a problem hiding this comment.
Good point and agreed, let me handle that in a separate PR for all the existing UR_L0_ENV vars.
nrspruit
added a commit
to intel/llvm
that referenced
this pull request
Oct 28, 2024
-pre-commit PR for oneapi-src/unified-runtime#2242 Signed-off-by: Neil R. Spruit <[email protected]>
pbalcer
approved these changes
Oct 28, 2024
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Oct 28, 2024
-pre-commit PR for oneapi-src/unified-runtime#2242 Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
pushed a commit
to nrspruit/unified-runtime
that referenced
this pull request
Oct 28, 2024
[L0] Enable Sysman Thru Env by default and have zesInit be optional
againull
pushed a commit
to intel/llvm
that referenced
this pull request
Oct 28, 2024
…15894) -pre-commit PR for oneapi-src/unified-runtime#2242 Signed-off-by: Neil R. Spruit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR_L0_ENABLE_SYSMAN_ENV_DEFAULT==0.
zesInit over sysman env init if the env allows it.
UR_L0_ENABLE_SYSMAN_ENV_DEFAULT==0 due to the env overwriting the
zesInit support.