[CUDA][HIP] Refactor guess local worksize funcs #1323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The guessLocalWorkSize func for cuda adapter was erroneously giving a factor of 2 even if it creates a global dim which is not the same as the user range without using any range rounding kernels. This reverts that. Also refactor the HIP version a little bit to remove an unnecessary check.
hdelan
changed the title
jchlanda
reviewed
Feb 8, 2024
|
I couldn't reopen this PR since I force pushed to the branch so this is the new PR #1326 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guessLocalWorkSize func for cuda adapter was erroneously giving a factor of 2 wg size for the x dimension, even if it creates a global dim which is not the same as the user range. This may have caused out of bounds accesses in the CUDA adapter. This reverts that.
Also refactor the HIP version a little bit to remove an unnecessary check.