[Common] Don't include Windows.h in ur_util.hpp #1260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
approved these changes
Jan 18, 2024
They turned up in my Windows L0+CL build, I just checked and they are also present on main so no. I'll split those out into a separate PR. |
Avoid transitively including Windows.h in headers which include ur_util.hpp.
kbenzie
force-pushed
the
benie/dont-include-windows.h-in-ur_info.hpp
branch
from
6036025 to
eba3905
Compare
8 tasks
kbenzie
added a commit
to kbenzie/unified-runtime
that referenced
this pull request
Jan 19, 2024
…ndows.h-in-ur_info.hpp [Common] Don't include Windows.h in ur_util.hpp
kbenzie
added a commit
to kbenzie/unified-runtime
that referenced
this pull request
Jan 22, 2024
…ndows.h-in-ur_info.hpp [Common] Don't include Windows.h in ur_util.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid transitively including Windows.h in headers which include ur_util.hpp.