Skip to content

Conversation

pbalcer
Copy link
Contributor

@pbalcer pbalcer commented Dec 19, 2023

This should fix all non-test related coverity issues except for:
https://scan7.scan.coverity.com/reports.htm#v21214/p15954/fileInstanceId=155217701&defectInstanceId=19136875&mergedDefectId=1574236, which is a race in the HIP adapter - that looks like it might be a false positive, but I'm not sure.

@pbalcer pbalcer requested review from a team as code owners December 19, 2023 14:12
@pbalcer pbalcer requested a review from mmoadeli December 19, 2023 14:12
@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@c90c8be). Click here to learn what that means.
Report is 2 commits behind head on main.

Files Patch % Lines
source/adapters/null/ur_null.cpp 0.00% 2 Missing ⚠️
source/common/ur_util.hpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1203   +/-   ##
=======================================
  Coverage        ?   15.73%           
=======================================
  Files           ?      223           
  Lines           ?    31465           
  Branches        ?     3555           
=======================================
  Hits            ?     4951           
  Misses          ?    26463           
  Partials        ?       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbalcer
Copy link
Contributor Author

pbalcer commented Dec 19, 2023

intel/llvm#12207

@aarongreig
Copy link
Contributor

I'll look into the hip issue, it looks a lot like a few other issues that came up around queue that I already marked as false positives

@wlemkows wlemkows merged commit f2e0d0f into oneapi-src:main Dec 20, 2023
@pbalcer pbalcer mentioned this pull request Jan 9, 2024
8 tasks
kbenzie pushed a commit to kbenzie/unified-runtime that referenced this pull request Jan 16, 2024
[cuda][null][common] fix a few coverity issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants