Skip to content

[HIP] Fix build with ROCm 6.0.0 #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 3, 2024
Merged

[HIP] Fix build with ROCm 6.0.0 #1198

merged 3 commits into from
Jan 3, 2024

Conversation

al42and
Copy link
Contributor

@al42and al42and commented Dec 16, 2023

I see some unit test failures, but there were quite a lot of known issues with earlier ROCm versions too.

@al42and al42and requested a review from a team as a code owner December 16, 2023 20:22
@al42and al42and requested a review from hdelan December 16, 2023 20:22
@al42and al42and changed the title Fix build with ROCm 6.0.0 [HIP] Fix build with ROCm 6.0.0 Dec 16, 2023
hdelan
hdelan reviewed Dec 18, 2023
View reviewed changes
GeorgeWeb
GeorgeWeb reviewed Dec 18, 2023
View reviewed changes
hdelan
hdelan approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@hdelan hdelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kbenzie kbenzie merged commit 749d8e5 into oneapi-src:main Jan 3, 2024
@kbenzie kbenzie mentioned this pull request Jan 3, 2024
Merged
kbenzie added a commit to kbenzie/unified-runtime that referenced this pull request Jan 3, 2024
@kbenzie
Merge pull request oneapi-src#1198 from al42and/aa-rocm6
41a0841 
[HIP] Fix build with ROCm 6.0.0
@kbenzie kbenzie mentioned this pull request Jan 3, 2024
Merged
8 tasks
againull pushed a commit to intel/llvm that referenced this pull request Jan 3, 2024
@kbenzie
[UR] Bump tag to 749d8e5 (#12281)
cdc645f 
* oneapi-src/unified-runtime#1198
* oneapi-src/unified-runtime#1172
* oneapi-src/unified-runtime#1025
* oneapi-src/unified-runtime#1052
* oneapi-src/unified-runtime#1114
* oneapi-src/unified-runtime#1201
@al42and al42and deleted the aa-rocm6 branch January 3, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeWeb GeorgeWeb GeorgeWeb left review comments

+1 more reviewer

@hdelan hdelan hdelan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@al42and @GeorgeWeb @hdelan @kbenzie