-
Notifications
You must be signed in to change notification settings - Fork 124
Closed
Labels
specificationChanges or additions to the specificationChanges or additions to the specification
Milestone
Description
Some UR enumerations are perhaps confusingly named and do not return the expected type as to what their name might suggest.
The two queries:
UR_DEVICE_INFO_PARTITION_PROPERTIES
: which is equivalent toCL_DEVICE_PARTITION_PROPERTIES
and returns an array ofur_device_partition_type_t
which indicates what partition schemes are supported by the device. In OpenCL this returns acl_device_partition_property[]
which is just an array ofintptr
, but makes sense to call this enum*_PROPERTIES
. However in UR we have a specific enum for these values so we should rename this enumeration perhaps toUR_DEVICE_INFO_PARTITION_TYPES
UR_DEVICE_INFO_PARTITION_TYPE
: is a query which returns the partition type of a sub-device. I.e. The properties passed tourDevicePartition
as aur_device_partition_property_t[]
. However, this name will now be confusing with the suggestion of renaming ofUR_DEVICE_INFO_PARTITION_PROPERTIES
. We should rename this enum to disambiguate between the two enumerations.
Metadata
Metadata
Assignees
Labels
specificationChanges or additions to the specificationChanges or additions to the specification