Skip to content

Clarify device query partition enumerations. #552

@veselypeta

Description

@veselypeta

Some UR enumerations are perhaps confusingly named and do not return the expected type as to what their name might suggest.

The two queries:

  • UR_DEVICE_INFO_PARTITION_PROPERTIES: which is equivalent to CL_DEVICE_PARTITION_PROPERTIES and returns an array of ur_device_partition_type_t which indicates what partition schemes are supported by the device. In OpenCL this returns a cl_device_partition_property[] which is just an array of intptr, but makes sense to call this enum *_PROPERTIES. However in UR we have a specific enum for these values so we should rename this enumeration perhaps to UR_DEVICE_INFO_PARTITION_TYPES
  • UR_DEVICE_INFO_PARTITION_TYPE: is a query which returns the partition type of a sub-device. I.e. The properties passed to urDevicePartition as a ur_device_partition_property_t[]. However, this name will now be confusing with the suggestion of renaming of UR_DEVICE_INFO_PARTITION_PROPERTIES. We should rename this enum to disambiguate between the two enumerations.

Metadata

Metadata

Assignees

No one assigned

    Labels

    specificationChanges or additions to the specification

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions