Skip to content

Conversation

@lukaszstolarczuk
Copy link
Contributor

@lukaszstolarczuk
Copy link
Contributor Author

Please let me know if this is something we want to do, and if so - should this be done for all params functions?

@lplewa
Copy link
Contributor

lplewa commented Dec 5, 2024

Please let me know if this is something we want to do, and if so - should this be done for all params functions?

can we workaround this in UR - i really dislike getter idea. As far i see it is only to std::cout configuration of the pool. This is not a great usecase to add new api

@igchor
Copy link
Contributor

igchor commented Dec 5, 2024

@lukaszstolarczuk I think we could just pre-generate that entire output in UR in DisjointPoolAllConfigs ctor. You can probably use std::stringstream to keep the same formatting and not having to modify the code too much.

@vinser52
Copy link
Contributor

vinser52 commented Dec 5, 2024

Please let me know if this is something we want to do, and if so - should this be done for all params functions?

can we workaround this in UR - i really dislike getter idea. As far i see it is only to std::cout configuration of the pool. This is not a great usecase to add new api

I agree with @lplewa I intentionally did not add the getter functions to the config API. I think it is a design issue in UR. UR should not use UMF config for their own needs. Probably UR can have their own structure to store configs values. Or use the idea that @igchor suggested.

@lukaszstolarczuk
Copy link
Contributor Author

Perfect, that's why I preped this simple draft. Much appreciate your feedback, I'll give it a try tomorrow.

@lukaszstolarczuk lukaszstolarczuk deleted the add-disjoint-config-getters branch December 5, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants