Skip to content

Add tests for utils_common to improve coverage #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

Add tests for utils_common to improve coverage #856

merged 1 commit into from
Nov 4, 2024

Conversation

staniewzki
Copy link
Contributor

@staniewzki staniewzki commented Oct 31, 2024 •
edited
Loading

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files

@lukaszstolarczuk lukaszstolarczuk changed the title Add tests for utils_common to improve coverity Add tests for utils_common to improve coverage Oct 31, 2024
lukaszstolarczuk
lukaszstolarczuk reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you're ready for merge, pls squash your changes into a single commit

@bratpiorka
Copy link
Contributor

note - please keep commits squashed unless you want to intentionally split the work

lukaszstolarczuk
lukaszstolarczuk reviewed Oct 31, 2024
View reviewed changes
@staniewzki staniewzki marked this pull request as ready for review November 4, 2024 15:37
@staniewzki staniewzki requested a review from a team as a code owner November 4, 2024 15:37
@bratpiorka
Copy link
Contributor

how the coverage changes with this PR?

@lukaszstolarczuk
Copy link
Contributor

how the coverage changes with this PR?

81,3 -> 81,6

@lukaszstolarczuk lukaszstolarczuk merged commit 01bb299 into oneapi-src:main Nov 4, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bratpiorka bratpiorka bratpiorka approved these changes

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staniewzki @bratpiorka @lukaszstolarczuk