Fix CUDA provider #810
Merged
Fix CUDA provider #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
approved these changes
Oct 21, 2024
vinser52
force-pushed
the
svinogra_cuda_fix
branch
from
11c6408 to
5becea6
Compare
vinser52
force-pushed
the
svinogra_cuda_fix
branch
from
5becea6 to
b20cf01
Compare
kswiecicki
approved these changes
Oct 22, 2024
|
Code coverage drops
to:
so the coverage of this PR seems to be:
@vinser52 is there a chance to improve that? |
I have not added any additional logic. I think before this PR the coverage for CUDA provider was low. Can we improve it in a separate PR (I can try to do that)? |
ldorau
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the PR #807 work, I found issues in the CUDA provider implementation. This PR fixes the problems and modifies CUDA tests.
Checklist