Add missing annotations to base_alloc_global #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever allocation larger than the largest allocation class was requested base_alloc_global was calling ba_os_alloc and wasn't marking the memory in any way. This was problematic as address returned from ba_os_alloc could have been the same as an address used for other instance of umf_ba_pool_t. If that other instance had been destroyed the memory address would still be marked as inaccessible.
vinser52
approved these changes
Mar 12, 2024
bratpiorka
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever allocation larger than the largest allocation class was requested base_alloc_global was calling ba_os_alloc and wasn't marking the memory in any way. This was problematic as address returned from ba_os_alloc could have been the same as an address used for other instance of umf_ba_pool_t. If that other instance had been destroyed the memory address would still be marked as inaccessible.
This fixes build on: #88