Skip to content

Conversation

akertesz
Copy link
Contributor

Signed-off-by: Audrey Kertesz [email protected]

Description

Initial commit of 2 more DPC++ FPGA code samples, fpga_reg and loop_unroll.
Linux only for now -- I've pulled Windows support for these samples to investigate a CI "long path" failure.

Type of change

  • Sample Migration (Moving sample from old repository after completing checklist established)

How Has This Been Tested?

Both samples have been passing stably in the former code sample repo's CI and in our internal test environment. They pre-exist from previous releases and are unmodified, so have been tested in IDEs. JSON updates were tested with JSON lint, but I'm relying on the automated CI to verify the test configuration are all correct.

Checklist for Moving samples:

Links and Details can be found in the samples WG Teams Files.

  • Review sample design with domain reviewers - I've reviewed all FPGA samples
  • Implement coding guidelines and ensure code quality - done.
  • Adhere to sample.json specification. https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-specification
  • Run jsonlint on sample.json to verify json syntax. www.jsonlint.com
  • Adhere to readme template
  • Ensure/create CI test configurations for sample (ciTests field) https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-ci-test-object
  • Enforce format via clang-format config file
  • Review DPC++ code with Paul Peterson -- both samples were approved by Paul in separate code reviews on the old repo.
  • Review readme with Tom Lenth or Joe Oster -- both samples were approved by Tom in separate code reviews on the old repo.
  • Tested using Dev Cloud when applicable -- tested in old repo CI pipeline and internal test environment with latest resources
  • No ONSAM JIRAs against these samples
  • No new dependencies or binaries

@akertesz akertesz requested review from anjgola and mkitez August 21, 2020 02:15
@akertesz
Copy link
Contributor Author

Anjali, Roman -- can one of you please approve + merge this for me?

@anjgola anjgola merged commit fc69f8e into oneapi-src:master Aug 21, 2020
@akertesz akertesz deleted the add-samples branch February 9, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants