Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Aug 20, 2020

Description

adding 3 existing oneDAL daal4py samples into Libraries/oneDAL folder for migration

Fixes # (issue)

Type of change

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

  • Sample Migration (Moving sample from old repository after completing checklist established)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • DevCloud interactive
  • Command Line
  • oneapi-cli
  • Visual Studio
  • Eclipse IDE
  • VSCode

Checklist for Moving samples:

Links and Details can be found in the samples WG Teams Files.

@JoeOster JoeOster self-requested a review August 20, 2020 21:30
rachel.oberman and others added 2 commits August 20, 2020 15:03
@ghost
Copy link
Author

ghost commented Aug 20, 2020

@JoeOster All requested changes have been addressed, please review and close when approved, thanks.

JoeOster
JoeOster previously approved these changes Aug 20, 2020
@JoeOster JoeOster requested a review from mkitez August 20, 2020 23:15
@ghost
Copy link
Author

ghost commented Aug 20, 2020

fixed the json issue, please run again, thanks

@ghost
Copy link
Author

ghost commented Aug 21, 2020

fixed again.

@ghost
Copy link
Author

ghost commented Aug 21, 2020

fixed again (hopefully last time)

anjgola
anjgola previously approved these changes Aug 21, 2020
Copy link
Contributor

@anjgola anjgola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review CI.

@ghost
Copy link
Author

ghost commented Aug 21, 2020

fixed sample.json again, please check again. not sure why it's not validating the file, since it's the exact same as the other one but in a different format. @mkitez @anjgola

@ghost
Copy link
Author

ghost commented Aug 21, 2020

@anjgola @mkitez please review before code freeze, thank you

Copy link
Contributor

@anjgola anjgola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggering CI

@JoeOster JoeOster merged commit 771cb73 into oneapi-src:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants