Skip to content

Conversation

@akertesz
Copy link
Contributor

@akertesz akertesz commented Aug 19, 2020

Signed-off-by: Audrey Kertesz [email protected]

Description

Initial commit of 20 DPC++ FPGA code samples. I'm bulk-migrating these on behalf of their original authors.

Type of change

  • Sample Migration (Moving sample from old repository after completing checklist established)

How Has This Been Tested?

All of the migrated samples have been passing stably in the former code sample repo's CI and in our internal test environment. 18/20 are samples that pre-exist from previous releases and are unmodified, so have been tested in IDEs. The two samples new to beta09 were tested to ensure they opened in Visual Studio.

JSON updates were tested with JSON lint, but I'm relying on the automated CI to verify the test configuration are all correct.

Checklist for Moving samples:

Links and Details can be found in the samples WG Teams Files.

  • Review sample design with domain reviewers - I've reviewed all FPGA samples
  • Implement coding guidelines and ensure code quality - done.
  • Adhere to sample.json specification. https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-specification
  • Run jsonlint on sample.json to verify json syntax. www.jsonlint.com
  • Adhere to readme template
  • Ensure/create CI test configurations for sample (ciTests field) https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-ci-test-object
  • Enforce format via clang-format config file
  • Review DPC++ code with Paul Peterson -- all samples were approved by Paul in separate code reviews on the old repo.
  • Review readme with Tom Lenth or Joe Oster -- all samples were approved by Tom in separate code reviews on the old repo.
  • Tested using Dev Cloud when applicable -- tested in old repo CI pipeline and internal test environment with latest resources
  • No ONSAM JIRAs against these samples
  • No new dependencies or binaries

@akertesz akertesz self-assigned this Aug 19, 2020
@akertesz akertesz requested a review from mkitez August 19, 2020 17:40
@akertesz
Copy link
Contributor Author

akertesz commented Aug 19, 2020

@pmpeter1 has already reviewed all 22 samples in this PR for coding guideline adherence (reviews on old repo)
Tom Lenth (who I can't find on GitHub) has done the same for all READMEs
I am the FPGA domain expert and I have already reviewed all of these.

For this reason I included only Roman @mkitez as a CI reviewer.

@akertesz akertesz requested a review from anjgola August 20, 2020 03:58
@akertesz akertesz merged commit a749efc into oneapi-src:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants