-
Notifications
You must be signed in to change notification settings - Fork 734
tools: adding IoT Connection Tools and ISD code samples #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mihai Tudor Panu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please send me confirmation via email if these samples are approved for move by @srdontha. If I have been informed and missed it please bump it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest this be reviewed according to ISD coding guidelines. It does not conforn to DPC++ direct coding guidelines, and I doubt it should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Propanu please add the ciTests
field in all sample.json
files according to https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-ci-test-object
Signed-off-by: Mihai Tudor Panu <[email protected]>
…orial Signed-off-by: Mihai Tudor Panu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the typical things are in place, no windows stuff, readme.md are fine, all of the licenses are 2020, json is in place
Forgot to comment out line oneapi-src#9, "warm up".
Fix missing bracket
Signed-off-by: Mihai Tudor Panu [email protected]