Skip to content

Conversation

Propanu
Copy link
Contributor

@Propanu Propanu commented Jul 2, 2020

Signed-off-by: Mihai Tudor Panu [email protected]

@anjgola anjgola requested review from mkitez, pmpeter1 and anjgola July 7, 2020 01:15
Copy link
Contributor

@anjgola anjgola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please send me confirmation via email if these samples are approved for move by @srdontha. If I have been informed and missed it please bump it.

Copy link

@pmpeter1 pmpeter1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest this be reviewed according to ISD coding guidelines. It does not conforn to DPC++ direct coding guidelines, and I doubt it should.

Copy link
Contributor

@mkitez mkitez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Propanu please add the ciTests field in all sample.json files according to https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-ci-test-object

@anjgola anjgola added PendingWGApproval Pending Approval from Samples WG and removed PendingWGApproval Pending Approval from Samples WG labels Jul 16, 2020
anjgola
anjgola previously approved these changes Jul 20, 2020
@anjgola anjgola requested a review from JoeOster July 20, 2020 20:50
Copy link
Contributor

@JoeOster JoeOster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the typical things are in place, no windows stuff, readme.md are fine, all of the licenses are 2020, json is in place

@Propanu Propanu requested a review from mkitez July 27, 2020 15:08
@anjgola anjgola merged commit 7074453 into oneapi-src:master Aug 4, 2020
keylbill added a commit to keylbill/oneAPI-samples that referenced this pull request Oct 28, 2022
Forgot to comment out line oneapi-src#9, "warm up".
jimmytwei pushed a commit to jimmytwei/oneAPI-samples that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants