Skip to content

Conversation

andrey4latyshev
Copy link
Contributor

@andrey4latyshev andrey4latyshev commented Aug 18, 2020

Description

The Hidden Markov Model DPC++ Sample (Dwarf). Implements Viterbi algorithm using DPC++.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Sample Migration (Moving sample from old repository after completing checklist established)

How Has This Been Tested?

  • Command Line
  • oneapi-cli
  • Visual Studio
  • Eclipse IDE
  • VSCode

Checklist for Moving samples:

Links and Details can be found in the samples WG Teams Files.

@samples-ci samples-ci requested review from a team, JoeOster, akertesz, mkitez, pmpeter1, praveenkk123 and sravanikonda and removed request for a team August 18, 2020 16:41
Copy link

@pmpeter1 pmpeter1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to align with samples style guidelines (mostly naming).

Should use dpc_common.hpp for async exception.

Shorter names that 'accessor' should be used. More aligned with the algorithm's purpose. You usually try and make the body of your kernel most descriptive and then choose your accessor, buffer, and host object names to match.

Given this is primarily a set of linear stages, how do you propose to optimize this to get good performance on an offload accelerator?

Copy link

@pmpeter1 pmpeter1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "dpc_common.hpp" not <dpc_common.hpp> This is a shared/common header not a system header file.

@anjgola
Copy link
Contributor

anjgola commented Aug 20, 2020

Status 8/20 am : Pending on changes requested from pmpeter1

@andrey4latyshev
Copy link
Contributor Author

Given this is primarily a set of linear stages, how do you propose to optimize this to get good performance on an offload accelerator?

The acceleration comes from the sequential filling the massive matrices/buffers in parallel and the memory that is always on device.

pmpeter1
pmpeter1 previously approved these changes Aug 20, 2020
praveenkk123
praveenkk123 previously approved these changes Aug 20, 2020
@andrey4latyshev andrey4latyshev dismissed stale reviews from praveenkk123 and pmpeter1 via f84fae1 August 20, 2020 19:31
JoeOster
JoeOster previously approved these changes Aug 20, 2020
Copy link
Contributor

@JoeOster JoeOster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to launch ci

mkitez
mkitez previously approved these changes Aug 21, 2020
Copy link
Contributor

@mkitez mkitez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggering CI

pmpeter1
pmpeter1 previously approved these changes Aug 21, 2020
@andrey4latyshev andrey4latyshev dismissed stale reviews from pmpeter1 and mkitez via 0d6f3ba August 21, 2020 13:45
@anjgola
Copy link
Contributor

anjgola commented Aug 22, 2020

@praveenkk123 , you can merge PR if you approve them and CI passes.

@anjgola anjgola merged commit 0003549 into oneapi-src:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants