-
Notifications
You must be signed in to change notification settings - Fork 735
Add Hidden Markov Model Dwarf Sample #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to align with samples style guidelines (mostly naming).
Should use dpc_common.hpp for async exception.
Shorter names that 'accessor' should be used. More aligned with the algorithm's purpose. You usually try and make the body of your kernel most descriptive and then choose your accessor, buffer, and host object names to match.
Given this is primarily a set of linear stages, how do you propose to optimize this to get good performance on an offload accelerator?
DirectProgramming/DPC++/GraphTraversal/hidden-markov-models/License.txt
Outdated
Show resolved
Hide resolved
DirectProgramming/DPC++/GraphTraversal/hidden-markov-models/README.md
Outdated
Show resolved
Hide resolved
DirectProgramming/DPC++/GraphTraversal/hidden-markov-models/src/hidden_markov_models.cpp
Show resolved
Hide resolved
DirectProgramming/DPC++/GraphTraversal/hidden-markov-models/src/hidden_markov_models.cpp
Show resolved
Hide resolved
DirectProgramming/DPC++/GraphTraversal/hidden-markov-models/src/hidden_markov_models.cpp
Outdated
Show resolved
Hide resolved
DirectProgramming/DPC++/GraphTraversal/hidden-markov-models/src/hidden_markov_models.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be "dpc_common.hpp" not <dpc_common.hpp> This is a shared/common header not a system header file.
Status 8/20 am : Pending on changes requested from pmpeter1 |
The acceleration comes from the sequential filling the massive matrices/buffers in parallel and the memory that is always on device. |
f84fae1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving to launch ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Triggering CI
@praveenkk123 , you can merge PR if you approve them and CI passes. |
Description
The Hidden Markov Model DPC++ Sample (Dwarf). Implements Viterbi algorithm using DPC++.
Type of change
How Has This Been Tested?
Checklist for Moving samples:
Links and Details can be found in the samples WG Teams Files.