-
Notifications
You must be signed in to change notification settings - Fork 735
Removed unused header file "chrono" from iso2dfd and particle-diffusion #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: avillarr <[email protected]>
Signed-off-by: avillarr <[email protected]>
…ME file. Change copyright to 2020 Signed-off-by: avillarr <[email protected]>
…ME file. Change copyright to 2020 Signed-off-by: avillarr <[email protected]>
…ME file. Change copyright to 2020 Signed-off-by: avillarr <[email protected]>
…ME file. Change copyright to 2020 Signed-off-by: avillarr <[email protected]>
…ME file. Change copyright to 2020 Signed-off-by: avillarr <[email protected]>
Signed-off-by: avillarr <[email protected]>
Signed-off-by: avillarr <[email protected]>
Signed-off-by: avillarr <[email protected]>
Signed-off-by: avillarr <[email protected]>
Signed-off-by: avillarr <[email protected]>
Signed-off-by: avillarr <[email protected]>
Signed-off-by: Alberto Villarreal <[email protected]>
Signed-off-by: Alberto Villarreal <[email protected]>
@JoeOster Thanks for the comment about the unused header file. I removed those includes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your readme statement about the dpc_common, but it isn't addressing Linux only Windows
I would include a statement such as what's used in the mandelbrot readme, if you want to continue to use your statement, I would add it to the bottom as a Troubleshhooting section or similar.
Signed-off-by: Alberto Villarreal <[email protected]>
Signed-off-by: Alberto Villarreal <[email protected]>
@JoeOster I added the General statement you suggested about the include path (Both for Linux and Windows). Deleted the warning for windows- It might be redundant and to maintain consistency with other code samples. Thanks for reviewing. |
Description
Removed unused header file "chrono" from iso2dfd and particle-diffusion.
Thanks to Joe Oster for pointing that out.
Fixes # (issue)
Deleted unused includes, simplifying code
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist for Moving samples:
Links and Details can be found in the samples WG Teams Files.