Skip to content

Conversation

Alberto-Villarreal
Copy link
Contributor

@Alberto-Villarreal Alberto-Villarreal commented Aug 17, 2020

Description

Removed unused header file "chrono" from iso2dfd and particle-diffusion.
Thanks to Joe Oster for pointing that out.

Fixes # (issue)

Deleted unused includes, simplifying code

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Command Line
  • oneapi-cli
  • Visual Studio
  • Eclipse IDE
  • VSCode

Checklist for Moving samples:

Links and Details can be found in the samples WG Teams Files.

Alberto-Villarreal and others added 16 commits July 13, 2020 19:43
…ME file. Change copyright to 2020

Signed-off-by: avillarr <[email protected]>
…ME file. Change copyright to 2020

Signed-off-by: avillarr <[email protected]>
…ME file. Change copyright to 2020

Signed-off-by: avillarr <[email protected]>
…ME file. Change copyright to 2020

Signed-off-by: avillarr <[email protected]>
…ME file. Change copyright to 2020

Signed-off-by: avillarr <[email protected]>
Signed-off-by: avillarr <[email protected]>
Signed-off-by: Alberto Villarreal <[email protected]>
Signed-off-by: Alberto Villarreal <[email protected]>
@Alberto-Villarreal
Copy link
Contributor Author

@JoeOster Thanks for the comment about the unused header file. I removed those includes.

Copy link
Contributor

@JoeOster JoeOster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your readme statement about the dpc_common, but it isn't addressing Linux only Windows

I would include a statement such as what's used in the mandelbrot readme, if you want to continue to use your statement, I would add it to the bottom as a Troubleshhooting section or similar.

https://github.com/Alberto-Villarreal/oneAPI-samples/tree/master/DirectProgramming/DPC%2B%2B/CombinationalLogic/mandelbrot

@Alberto-Villarreal
Copy link
Contributor Author

I like your readme statement about the dpc_common, but it isn't addressing Linux only Windows

I would include a statement such as what's used in the mandelbrot readme, if you want to continue to use your statement, I would add it to the bottom as a Troubleshhooting section or similar.

https://github.com/Alberto-Villarreal/oneAPI-samples/tree/master/DirectProgramming/DPC%2B%2B/CombinationalLogic/mandelbrot

@JoeOster I added the General statement you suggested about the include path (Both for Linux and Windows). Deleted the warning for windows- It might be redundant and to maintain consistency with other code samples. Thanks for reviewing.

@JoeOster JoeOster merged commit 5ef75f4 into oneapi-src:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants