Skip to content

Conversation

bdmoore1
Copy link
Contributor

Existing Sample Changes

Description

In May 2021, I updated the sample README files to include instructions on how to connect to a node on DevCloud. I forgot to create a PR for the Modin sample. This PR is to add instructions for how to connect to a node on DevCloud to the Modin Getting Started sample README.

Fixes Issue#

External Dependencies

none

Type of change

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

  • [x ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Command Line
  • oneapi-cli
  • Visual Studio
  • Eclipse IDE
  • [ x] VSCode
  • When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

praveenkk123
praveenkk123 previously approved these changes Jan 24, 2022
@praveenkk123 praveenkk123 requested a review from tomlenth January 24, 2022 21:07
tomlenth
tomlenth previously approved these changes Feb 1, 2022
@praveenkk123
Copy link
Contributor

hi, there is a merge conflict. can you please fix that

@praveenkk123 praveenkk123 dismissed stale reviews from tomlenth and themself via 4b374b2 February 2, 2022 22:46
Copy link
Contributor

@praveenkk123 praveenkk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve after fixing merge conflicts

@praveenkk123 praveenkk123 merged commit 79eb941 into oneapi-src:master Feb 2, 2022
@bdmoore1 bdmoore1 deleted the bdmoore1-modin-gstarted-readme-nodemode-update branch February 2, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants