-
Notifications
You must be signed in to change notification settings - Fork 735
Initial pull request for openmp_reduction and dpc_reduce examples #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a few things that need to be fixed
- chrono commands should go through dpc_common
- The use of '\n' is recommended over std::endl except if the explicit flush is desired
- Needs a License.txt file in the root of both
samples
…still had <chrono> and the omp_common.hpp file. They have been removed. Signed-off-by: todd.erdner <[email protected]>
DirectProgramming/DPC++/ParallelPatterns/openmp_reduction/sample.json
Outdated
Show resolved
Hide resolved
…ed all calls to "std::endl" and replaced with " \n" Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
@mkitez - citests are in place, but Linux didn't run. I also don't see the report in TeamCity |
Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trigger CI
@JoeOster Can you please review as well. @praveenkk123 If this meets all the checklist please click on 'merge and squash' and go ahead and merge it. |
DirectProgramming/DPC++/ParallelPatterns/openmp_reduction/License.txt
Outdated
Show resolved
Hide resolved
DirectProgramming/DPC++/ParallelPatterns/dpc_reduce/License.txt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the License.txt files, by removing date
Signed-off-by: todd.erdner <[email protected]>
@JoeOster - removed dates from the License.txt file and pushed to master. |
@pmpeter1 , Hi Paul can you please confirm if you have reviewed and you are OK with these samples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dpc_common includes need the comments about how to find this shared file.
Would be good to rename the functions in the DPC++ sample to also include the "purpose" of the functions in the name and not just the execution mode like is done in the OpenMP sample.
These issues were resolved |
…er Paul's comments. Signed-off-by: todd.erdner <[email protected]>
…i_*) per suggestion from Paul. Signed-off-by: todd.erdner <[email protected]>
@pmpeter1 - these two items are now fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Description
Initial pull request for openMP_reductino and dpc_reduce examples.
Fixes # (issue)
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist for Moving samples:
Links and Details can be found in the samples WG Teams Files.