Skip to content

fix deprecation notice #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2021
Merged

fix deprecation notice #682

merged 1 commit into from
Sep 29, 2021

Conversation

ericlars
Copy link
Contributor

@ericlars ericlars commented Sep 24, 2021

Existing Sample Changes

Description

Recent dpcpp compilers issue a deprecation notice for get_cl_code(). This patch calls new code() api when possible, falling back to get_cl_code() when not.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Implement fixes for ONSAM Jiras

How Has This Been Tested?

  • [ X ] Command Line (linux)
  • oneapi-cli
  • Visual Studio
  • Eclipse IDE
  • VSCode
  • When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

@@ -27,6 +27,7 @@ using namespace oneapi;

#include "input_generator.hpp"
#include "black_scholes.hpp"
#include "code_wrapper.tpp"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo? tpp => hpp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not uncommon to use the tpp extension for template headers, especially when it contains template meta programs. I'm unaware of any guidelines, but don't have any strong preference.

Copy link
Contributor

@sknepper sknepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks!
@JoeOster or @anjgola , can you please launch any needed CI runs?

@sknepper
Copy link
Contributor

All necessary CI tests passed.

@sknepper sknepper merged commit 4bed52e into oneapi-src:master Sep 29, 2021
JoeOster added a commit that referenced this pull request Sep 29, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

Co-authored-by: ericlars <[email protected]>
mdbtucker pushed a commit that referenced this pull request Oct 13, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* Improve CMakeLists.txt for FPGA fast_recompile

Simplify the 'fpga_emu' target and add a 'report' target.
Only the hardware target needs to use the explicit commands.

Signed-off-by: Mark Mendell <[email protected]>

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 pushed a commit that referenced this pull request Nov 2, 2021
…PI (#726)

* Adding mandelbrot sample to the repository

Signed-off-by: vmadanan <[email protected]>

* Adding changes to mandelbrot to remove libsycl-complex.so dependency

* namespace change for Monte Carlo

* Updated samples to newest coding guidelines

* Updating samples- Mandelbrot, DCT and MonteCarlo with newest coding guidelines

* Fixing warnings for DCT

* Added ifdef to remove warnings

* Fixed issues with mandelbrot/montecarlopi in debug/release

* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* Fixed warnings on using deprecated namespace sycl::ONEAPI

Signed-off-by: vmadanan <[email protected]>

Co-authored-by: varsha madananth <[email protected]>
Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 added a commit that referenced this pull request Nov 2, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* Remove oneVPL sample source

* Update json

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
Co-authored-by: praveenkk123 <[email protected]>
praveenkk123 pushed a commit that referenced this pull request Nov 3, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* initial commit for RenderingToolkit GSG sample proposal

* signed inital commit for RenderingToolkit GSG intro samples

Signed-off-by: Michael R Carroll <[email protected]>

* Added generated GUIDS to .repo-tools/Docs_Automation/guids.json (signed commit)

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

Moving README.md content to individual folders

* Order samples folders

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

* Adding per sample component README.md files

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

* Adding percomponent LICENSE placeholder files (to be reviewed)

Signed-off-by: Michael R Carroll <[email protected]>

* Adding converted .pfm input file. This file could help users if they get stuck. It is not too big.

Signed-off-by: Michael R Carroll <[email protected]>

* Updating sample.json files per Joseph Oster guidance

Signed-off-by: Michael R Carroll <[email protected]>

* Updates to oidn README.md for linux and macos

Signed-off-by: Michael R Carroll <[email protected]>

* Update README for library requirements

Signed-off-by: Michael R Carroll <[email protected]>

* New branch for just oidn sample

Signed-off-by: Michael R Carroll <[email protected]>

* Add description to base README.md

Signed-off-by: Michael R Carroll <[email protected]>

* removing overlapping content. overlap to RenderingToolkit-ospray branch

Signed-off-by: Michael R Carroll <[email protected]>

* Updates for the oidn README.md

Signed-off-by: Michael R Carroll <[email protected]>

* clang-format for source

Signed-off-by: Michael R Carroll <[email protected]>

* README.md update

Signed-off-by: Michael R Carroll <[email protected]>

* Triage samples.json for CI process. Hopefully this unblocks!

Signed-off-by: Michael R Carroll <[email protected]>

* Escape the spaces for CI in sample.json

Signed-off-by: Michael R Carroll <[email protected]>

* Escape extra quotes for CI in sample.json

Signed-off-by: Michael R Carroll <[email protected]>

* Should be no Release folder for sample.json on macos or lin. It has been removed

Signed-off-by: Michael R Carroll <[email protected]>

* Escapes for sample.json input files and exe invoke

Signed-off-by: Michael R Carroll <[email protected]>

* README.md updates for better pathing and simplified build

Signed-off-by: Michael R Carroll <[email protected]>

* CMakeLists convenience updates

Signed-off-by: Michael R Carroll <[email protected]>

* Changing paths for better CI

Signed-off-by: Michael R Carroll <[email protected]>

* Nameing in CMakeLists for global variables build fix

Signed-off-by: Michael R Carroll <[email protected]>

* Update sample.json to take our oneapi env... check paths to input images (OK)

Signed-off-by: Michael R Carroll <[email protected]>

* fix typo/text ommission in sample.json to unblock CI

Signed-off-by: Michael R Carroll <[email protected]>

* Update sample.json

* sample.json to match for macos (env vars)

* Healthier CMakeLists for macos and c++11 on all platforms

Signed-off-by: Michael R Carroll <[email protected]>

* Update samples.json for better Macos env vars... (CI Only)

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 pushed a commit that referenced this pull request Nov 3, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* initial commit for RenderingToolkit GSG sample proposal

* signed inital commit for RenderingToolkit GSG intro samples

Signed-off-by: Michael R Carroll <[email protected]>

* Added generated GUIDS to .repo-tools/Docs_Automation/guids.json (signed commit)

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

Moving README.md content to individual folders

* Order samples folders

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

* Adding per sample component README.md files

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

* Adding percomponent LICENSE placeholder files (to be reviewed)

Signed-off-by: Michael R Carroll <[email protected]>

* Adding converted .pfm input file. This file could help users if they get stuck. It is not too big.

Signed-off-by: Michael R Carroll <[email protected]>

* Updating sample.json files per Joseph Oster guidance

Signed-off-by: Michael R Carroll <[email protected]>

* Updates to oidn README.md for linux and macos

Signed-off-by: Michael R Carroll <[email protected]>

* Update README for library requirements

Signed-off-by: Michael R Carroll <[email protected]>

* New branch for just openvkl sample

Signed-off-by: Michael R Carroll <[email protected]>

* Add description to base README.md

Signed-off-by: Michael R Carroll <[email protected]>

* removing overlapping content. overlap to RenderingToolkit-ospray branch

Signed-off-by: Michael R Carroll <[email protected]>

* Updates for the embree README.md

Signed-off-by: Michael R Carroll <[email protected]>

* clang-format for source

Signed-off-by: Michael R Carroll <[email protected]>

* Escape the spaces for CI and get the correct vklExamples.exe in sample.json

Signed-off-by: Michael R Carroll <[email protected]>

* Escape extra quotes for CI in sample.json

Signed-off-by: Michael R Carroll <[email protected]>

* Should be no Release folder for sample.json on macos or lin. It has been removed

Signed-off-by: Michael R Carroll <[email protected]>

* Escape for accurate exe invoke

Signed-off-by: Michael R Carroll <[email protected]>

* openvkl README updates

Signed-off-by: Michael R Carroll <[email protected]>

* CMakeLists.txt simplification updates

Signed-off-by: Michael R Carroll <[email protected]>

* Staging files into CI friendly directories. Should have been done before README.md from 2 commits prior

Signed-off-by: Michael R Carroll <[email protected]>

* Update CMakeLists.txt for 03_openvkl_gsg... C linkage errors

* CMakeLists.txt updates for variable name consistency

Signed-off-by: Michael R Carroll <[email protected]>

* Update for CMakeLists.txt... thought it was merged before. This should unblock CI!

Signed-off-by: Michael R Carroll <[email protected]>

* Update sample.json

* samples.json to match embree env concerns

* CMakeLists health updates

Signed-off-by: Michael R Carroll <[email protected]>

* Remvove rkcommon header for not applicable project

Signed-off-by: Michael R Carroll <[email protected]>

* Update sample.json for healthier pathing... CI affect only.

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 pushed a commit that referenced this pull request Nov 4, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* initial commit for RenderingToolkit GSG sample proposal

* signed inital commit for RenderingToolkit GSG intro samples

Signed-off-by: Michael R Carroll <[email protected]>

* Added generated GUIDS to .repo-tools/Docs_Automation/guids.json (signed commit)

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

Moving README.md content to individual folders

* Order samples folders

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

* Adding per sample component README.md files

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

* Adding percomponent LICENSE placeholder files (to be reviewed)

Signed-off-by: Michael R Carroll <[email protected]>

* Adding converted .pfm input file. This file could help users if they get stuck. It is not too big.

Signed-off-by: Michael R Carroll <[email protected]>

* Updating sample.json files per Joseph Oster guidance

Signed-off-by: Michael R Carroll <[email protected]>

* Updates to oidn README.md for linux and macos

Signed-off-by: Michael R Carroll <[email protected]>

* Update README for library requirements

Signed-off-by: Michael R Carroll <[email protected]>

* New branch for just OSPRay sample

Signed-off-by: Michael R Carroll <[email protected]>

* Add description to base README.md

Signed-off-by: Michael R Carroll <[email protected]>

* Documentation updates

Signed-off-by: Michael R Carroll <[email protected]>

* clang-format for source

Signed-off-by: Michael R Carroll <[email protected]>

* Escape extra quotes for CI and get the correct ospTutorialCpp.exe in sample.json

Signed-off-by: Michael R Carroll <[email protected]>

* Should be no Release folder for sample.json on macos or lin. It has been removed

Signed-off-by: Michael R Carroll <[email protected]>

* Escape for accurate exe invoke

Signed-off-by: Michael R Carroll <[email protected]>

* README.md ospray updates... and some root GSG file staging

Signed-off-by: Michael R Carroll <[email protected]>

* staging ospray for better heirarchy for CI

Signed-off-by: Michael R Carroll <[email protected]>

* CMakeLists updates for better CI

Signed-off-by: Michael R Carroll <[email protected]>

* CMakeLists.txt update for variable consistency

Signed-off-by: Michael R Carroll <[email protected]>

* Update sample.json

* sample.json fixes similar to embree...: remove env, fix pathing

* Health fixes for cmakelists

Signed-off-by: Michael R Carroll <[email protected]>

* Fix MacOS: Update for rkcommon support lib CMakeLists search path

Signed-off-by: Michael R Carroll <[email protected]>

* Hopefully better pathing for macos oneapi rk runtime libs (CI only fix)

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 pushed a commit that referenced this pull request Nov 4, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* initial commit for RenderingToolkit GSG sample proposal

* signed inital commit for RenderingToolkit GSG intro samples

Signed-off-by: Michael R Carroll <[email protected]>

* Added generated GUIDS to .repo-tools/Docs_Automation/guids.json (signed commit)

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

Moving README.md content to individual folders

* Order samples folders

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

* Adding per sample component README.md files

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

* Adding percomponent LICENSE placeholder files (to be reviewed)

Signed-off-by: Michael R Carroll <[email protected]>

* Adding converted .pfm input file. This file could help users if they get stuck. It is not too big.

Signed-off-by: Michael R Carroll <[email protected]>

* Updating sample.json files per Joseph Oster guidance

Signed-off-by: Michael R Carroll <[email protected]>

* Updates to oidn README.md for linux and macos

Signed-off-by: Michael R Carroll <[email protected]>

* Update README for library requirements

Signed-off-by: Michael R Carroll <[email protected]>

* New branch for just embree sample

Signed-off-by: Michael R Carroll <[email protected]>

* Add description to base README.md

Signed-off-by: Michael R Carroll <[email protected]>

* removing overlapping content. overlap to RenderingToolkit-ospray branch

Signed-off-by: Michael R Carroll <[email protected]>

* Updates for embree README.md

Signed-off-by: Michael R Carroll <[email protected]>

* Updates for the embree README.md (editorial)

Signed-off-by: Michael R Carroll <[email protected]>

* clang-format for source

Signed-off-by: Michael R Carroll <[email protected]>

* Escape extra quotes for CI and get the correct minimal.exe in sample.json

Signed-off-by: Michael R Carroll <[email protected]>

* Should be no Release folder for sample.json on macos or lin. It has been removed

Signed-off-by: Michael R Carroll <[email protected]>

* Escape for accurate exe invoke

Signed-off-by: Michael R Carroll <[email protected]>

* Updates for CMakeLists.txt and sample.json to be more adaptable for CI and public build

Signed-off-by: Michael R Carroll <[email protected]>

* Update some errors in embree README.md

Signed-off-by: Michael R Carroll <[email protected]>

* Moving file heirarchy to RenderingToolkit/GettingStarted

Signed-off-by: Michael R Carroll <[email protected]>

* CMakeLists change for variable consistency

Signed-off-by: Michael R Carroll <[email protected]>

* Update sample.json

* Update sample.json for DYLD_LIBRARY_PATH CI workaround

* CMakeLists health updates

Signed-off-by: Michael R Carroll <[email protected]>

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 pushed a commit that referenced this pull request Dec 1, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* correct IntelPython_XGBoost_Performance sample

Signed-off-by: Alexander Myskov <[email protected]>

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 pushed a commit that referenced this pull request Dec 7, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* rm plus, Fixes Issue#ONSAM-1418

* Update sample.json

add install flatbuffers

* Update sample.json

add missed package used in TF2.5

* update according to the review comment

make code be better

* rename lpot to inc

* fix sample.json error and use full name of INC

* use full name to replace INC, format sample.json

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 added a commit that referenced this pull request Dec 7, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 added a commit that referenced this pull request Dec 7, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 pushed a commit that referenced this pull request Dec 7, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* Improve CMakeLists.txt for FPGA fast_recompile

Simplify the 'fpga_emu' target and add a 'report' target.
Only the hardware target needs to use the explicit commands.

Signed-off-by: Mark Mendell <[email protected]>

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 pushed a commit that referenced this pull request Dec 7, 2021
…PI (#726)

* Adding mandelbrot sample to the repository

Signed-off-by: vmadanan <[email protected]>

* Adding changes to mandelbrot to remove libsycl-complex.so dependency

* namespace change for Monte Carlo

* Updated samples to newest coding guidelines

* Updating samples- Mandelbrot, DCT and MonteCarlo with newest coding guidelines

* Fixing warnings for DCT

* Added ifdef to remove warnings

* Fixed issues with mandelbrot/montecarlopi in debug/release

* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* Fixed warnings on using deprecated namespace sycl::ONEAPI

Signed-off-by: vmadanan <[email protected]>

Co-authored-by: varsha madananth <[email protected]>
Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 added a commit that referenced this pull request Dec 7, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* Remove oneVPL sample source

* Update json

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
Co-authored-by: praveenkk123 <[email protected]>
praveenkk123 pushed a commit that referenced this pull request Dec 7, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* initial commit for RenderingToolkit GSG sample proposal

* signed inital commit for RenderingToolkit GSG intro samples

Signed-off-by: Michael R Carroll <[email protected]>

* Added generated GUIDS to .repo-tools/Docs_Automation/guids.json (signed commit)

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

Moving README.md content to individual folders

* Order samples folders

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

* Adding per sample component README.md files

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

* Adding percomponent LICENSE placeholder files (to be reviewed)

Signed-off-by: Michael R Carroll <[email protected]>

* Adding converted .pfm input file. This file could help users if they get stuck. It is not too big.

Signed-off-by: Michael R Carroll <[email protected]>

* Updating sample.json files per Joseph Oster guidance

Signed-off-by: Michael R Carroll <[email protected]>

* Updates to oidn README.md for linux and macos

Signed-off-by: Michael R Carroll <[email protected]>

* Update README for library requirements

Signed-off-by: Michael R Carroll <[email protected]>

* New branch for just oidn sample

Signed-off-by: Michael R Carroll <[email protected]>

* Add description to base README.md

Signed-off-by: Michael R Carroll <[email protected]>

* removing overlapping content. overlap to RenderingToolkit-ospray branch

Signed-off-by: Michael R Carroll <[email protected]>

* Updates for the oidn README.md

Signed-off-by: Michael R Carroll <[email protected]>

* clang-format for source

Signed-off-by: Michael R Carroll <[email protected]>

* README.md update

Signed-off-by: Michael R Carroll <[email protected]>

* Triage samples.json for CI process. Hopefully this unblocks!

Signed-off-by: Michael R Carroll <[email protected]>

* Escape the spaces for CI in sample.json

Signed-off-by: Michael R Carroll <[email protected]>

* Escape extra quotes for CI in sample.json

Signed-off-by: Michael R Carroll <[email protected]>

* Should be no Release folder for sample.json on macos or lin. It has been removed

Signed-off-by: Michael R Carroll <[email protected]>

* Escapes for sample.json input files and exe invoke

Signed-off-by: Michael R Carroll <[email protected]>

* README.md updates for better pathing and simplified build

Signed-off-by: Michael R Carroll <[email protected]>

* CMakeLists convenience updates

Signed-off-by: Michael R Carroll <[email protected]>

* Changing paths for better CI

Signed-off-by: Michael R Carroll <[email protected]>

* Nameing in CMakeLists for global variables build fix

Signed-off-by: Michael R Carroll <[email protected]>

* Update sample.json to take our oneapi env... check paths to input images (OK)

Signed-off-by: Michael R Carroll <[email protected]>

* fix typo/text ommission in sample.json to unblock CI

Signed-off-by: Michael R Carroll <[email protected]>

* Update sample.json

* sample.json to match for macos (env vars)

* Healthier CMakeLists for macos and c++11 on all platforms

Signed-off-by: Michael R Carroll <[email protected]>

* Update samples.json for better Macos env vars... (CI Only)

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 pushed a commit that referenced this pull request Dec 7, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* initial commit for RenderingToolkit GSG sample proposal

* signed inital commit for RenderingToolkit GSG intro samples

Signed-off-by: Michael R Carroll <[email protected]>

* Added generated GUIDS to .repo-tools/Docs_Automation/guids.json (signed commit)

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

Moving README.md content to individual folders

* Order samples folders

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

* Adding per sample component README.md files

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

* Adding percomponent LICENSE placeholder files (to be reviewed)

Signed-off-by: Michael R Carroll <[email protected]>

* Adding converted .pfm input file. This file could help users if they get stuck. It is not too big.

Signed-off-by: Michael R Carroll <[email protected]>

* Updating sample.json files per Joseph Oster guidance

Signed-off-by: Michael R Carroll <[email protected]>

* Updates to oidn README.md for linux and macos

Signed-off-by: Michael R Carroll <[email protected]>

* Update README for library requirements

Signed-off-by: Michael R Carroll <[email protected]>

* New branch for just openvkl sample

Signed-off-by: Michael R Carroll <[email protected]>

* Add description to base README.md

Signed-off-by: Michael R Carroll <[email protected]>

* removing overlapping content. overlap to RenderingToolkit-ospray branch

Signed-off-by: Michael R Carroll <[email protected]>

* Updates for the embree README.md

Signed-off-by: Michael R Carroll <[email protected]>

* clang-format for source

Signed-off-by: Michael R Carroll <[email protected]>

* Escape the spaces for CI and get the correct vklExamples.exe in sample.json

Signed-off-by: Michael R Carroll <[email protected]>

* Escape extra quotes for CI in sample.json

Signed-off-by: Michael R Carroll <[email protected]>

* Should be no Release folder for sample.json on macos or lin. It has been removed

Signed-off-by: Michael R Carroll <[email protected]>

* Escape for accurate exe invoke

Signed-off-by: Michael R Carroll <[email protected]>

* openvkl README updates

Signed-off-by: Michael R Carroll <[email protected]>

* CMakeLists.txt simplification updates

Signed-off-by: Michael R Carroll <[email protected]>

* Staging files into CI friendly directories. Should have been done before README.md from 2 commits prior

Signed-off-by: Michael R Carroll <[email protected]>

* Update CMakeLists.txt for 03_openvkl_gsg... C linkage errors

* CMakeLists.txt updates for variable name consistency

Signed-off-by: Michael R Carroll <[email protected]>

* Update for CMakeLists.txt... thought it was merged before. This should unblock CI!

Signed-off-by: Michael R Carroll <[email protected]>

* Update sample.json

* samples.json to match embree env concerns

* CMakeLists health updates

Signed-off-by: Michael R Carroll <[email protected]>

* Remvove rkcommon header for not applicable project

Signed-off-by: Michael R Carroll <[email protected]>

* Update sample.json for healthier pathing... CI affect only.

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 pushed a commit that referenced this pull request Dec 7, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* initial commit for RenderingToolkit GSG sample proposal

* signed inital commit for RenderingToolkit GSG intro samples

Signed-off-by: Michael R Carroll <[email protected]>

* Added generated GUIDS to .repo-tools/Docs_Automation/guids.json (signed commit)

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

Moving README.md content to individual folders

* Order samples folders

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

* Adding per sample component README.md files

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

* Adding percomponent LICENSE placeholder files (to be reviewed)

Signed-off-by: Michael R Carroll <[email protected]>

* Adding converted .pfm input file. This file could help users if they get stuck. It is not too big.

Signed-off-by: Michael R Carroll <[email protected]>

* Updating sample.json files per Joseph Oster guidance

Signed-off-by: Michael R Carroll <[email protected]>

* Updates to oidn README.md for linux and macos

Signed-off-by: Michael R Carroll <[email protected]>

* Update README for library requirements

Signed-off-by: Michael R Carroll <[email protected]>

* New branch for just OSPRay sample

Signed-off-by: Michael R Carroll <[email protected]>

* Add description to base README.md

Signed-off-by: Michael R Carroll <[email protected]>

* Documentation updates

Signed-off-by: Michael R Carroll <[email protected]>

* clang-format for source

Signed-off-by: Michael R Carroll <[email protected]>

* Escape extra quotes for CI and get the correct ospTutorialCpp.exe in sample.json

Signed-off-by: Michael R Carroll <[email protected]>

* Should be no Release folder for sample.json on macos or lin. It has been removed

Signed-off-by: Michael R Carroll <[email protected]>

* Escape for accurate exe invoke

Signed-off-by: Michael R Carroll <[email protected]>

* README.md ospray updates... and some root GSG file staging

Signed-off-by: Michael R Carroll <[email protected]>

* staging ospray for better heirarchy for CI

Signed-off-by: Michael R Carroll <[email protected]>

* CMakeLists updates for better CI

Signed-off-by: Michael R Carroll <[email protected]>

* CMakeLists.txt update for variable consistency

Signed-off-by: Michael R Carroll <[email protected]>

* Update sample.json

* sample.json fixes similar to embree...: remove env, fix pathing

* Health fixes for cmakelists

Signed-off-by: Michael R Carroll <[email protected]>

* Fix MacOS: Update for rkcommon support lib CMakeLists search path

Signed-off-by: Michael R Carroll <[email protected]>

* Hopefully better pathing for macos oneapi rk runtime libs (CI only fix)

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 pushed a commit that referenced this pull request Dec 7, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* initial commit for RenderingToolkit GSG sample proposal

* signed inital commit for RenderingToolkit GSG intro samples

Signed-off-by: Michael R Carroll <[email protected]>

* Added generated GUIDS to .repo-tools/Docs_Automation/guids.json (signed commit)

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

Moving README.md content to individual folders

* Order samples folders

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

* Adding per sample component README.md files

Signed-off-by: Michael R Carroll <[email protected]>

* Update README.md

* Adding percomponent LICENSE placeholder files (to be reviewed)

Signed-off-by: Michael R Carroll <[email protected]>

* Adding converted .pfm input file. This file could help users if they get stuck. It is not too big.

Signed-off-by: Michael R Carroll <[email protected]>

* Updating sample.json files per Joseph Oster guidance

Signed-off-by: Michael R Carroll <[email protected]>

* Updates to oidn README.md for linux and macos

Signed-off-by: Michael R Carroll <[email protected]>

* Update README for library requirements

Signed-off-by: Michael R Carroll <[email protected]>

* New branch for just embree sample

Signed-off-by: Michael R Carroll <[email protected]>

* Add description to base README.md

Signed-off-by: Michael R Carroll <[email protected]>

* removing overlapping content. overlap to RenderingToolkit-ospray branch

Signed-off-by: Michael R Carroll <[email protected]>

* Updates for embree README.md

Signed-off-by: Michael R Carroll <[email protected]>

* Updates for the embree README.md (editorial)

Signed-off-by: Michael R Carroll <[email protected]>

* clang-format for source

Signed-off-by: Michael R Carroll <[email protected]>

* Escape extra quotes for CI and get the correct minimal.exe in sample.json

Signed-off-by: Michael R Carroll <[email protected]>

* Should be no Release folder for sample.json on macos or lin. It has been removed

Signed-off-by: Michael R Carroll <[email protected]>

* Escape for accurate exe invoke

Signed-off-by: Michael R Carroll <[email protected]>

* Updates for CMakeLists.txt and sample.json to be more adaptable for CI and public build

Signed-off-by: Michael R Carroll <[email protected]>

* Update some errors in embree README.md

Signed-off-by: Michael R Carroll <[email protected]>

* Moving file heirarchy to RenderingToolkit/GettingStarted

Signed-off-by: Michael R Carroll <[email protected]>

* CMakeLists change for variable consistency

Signed-off-by: Michael R Carroll <[email protected]>

* Update sample.json

* Update sample.json for DYLD_LIBRARY_PATH CI workaround

* CMakeLists health updates

Signed-off-by: Michael R Carroll <[email protected]>

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 pushed a commit that referenced this pull request Dec 7, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* correct IntelPython_XGBoost_Performance sample

Signed-off-by: Alexander Myskov <[email protected]>

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 pushed a commit that referenced this pull request Dec 7, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* rm plus, Fixes Issue#ONSAM-1418

* Update sample.json

add install flatbuffers

* Update sample.json

add missed package used in TF2.5

* update according to the review comment

make code be better

* rename lpot to inc

* fix sample.json error and use full name of INC

* use full name to replace INC, format sample.json

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
MichaelRoyceCarroll pushed a commit to MichaelRoyceCarroll/oneAPI-samples that referenced this pull request Jan 14, 2022
* ONSAM-1414 Broken Link in Headers (oneapi-src#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (oneapi-src#682)

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
praveenkk123 added a commit that referenced this pull request Mar 8, 2022
* Update initial master commits to development branch (#789)

* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>

* Initial commit for Render Kit 05 ispc sample updates

Signed-off-by: Michael R Carroll <[email protected]>

* Code requirement fixes for RenderKit 05ispc

Signed-off-by: Michael R Carroll <[email protected]>

* include folders are now created during compilation for fix on Linux and Darwin

* Third party program notification updates

Signed-off-by: Michael R Carroll <[email protected]>

* Update RenderingToolkit/GettingStarted/05_ispc_gsg/src/simple.ispc

Co-authored-by: tpyra <[email protected]>

* Update RenderingToolkit/GettingStarted/05_ispc_gsg/src/simple.cpp

Co-authored-by: tpyra <[email protected]>

Co-authored-by: praveenkk123 <[email protected]>
Co-authored-by: JoeOster <[email protected]>
Co-authored-by: ericlars <[email protected]>
Co-authored-by: Piotr Kanclerz <[email protected]>
Co-authored-by: tpyra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants