Skip to content

add oneDNN and oneCCL samples #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 24, 2020
Merged

add oneDNN and oneCCL samples #58

merged 11 commits into from
Aug 24, 2020

Conversation

louie-tsai
Copy link
Contributor

Signed-off-by: ltsai1 [email protected]
add oneDNN and oneCCL samples

@JoeOster JoeOster requested review from JoeOster, anjgola and mkitez August 7, 2020 14:52
anjgola
anjgola previously approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@anjgola anjgola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggering CI.

@anjgola
Copy link
Contributor

anjgola commented Aug 7, 2020

Failed due to sample.json syntax error. Please follow Instructions to move provided that have the details to validate jsons.

@louie-tsai louie-tsai changed the title add oneDNN and oneCCL samples [WIP] add oneDNN and oneCCL samples Aug 7, 2020
@JoeOster JoeOster requested a review from pmpeter1 August 11, 2020 16:27
anjgola
anjgola previously approved these changes Aug 20, 2020
View reviewed changes
sravanikonda
sravanikonda requested changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@sravanikonda sravanikonda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change compiler name from Intel oneAPI DPC++ Compiler to Intel oneAPI DPC++/C++ Compiler

@louie-tsai louie-tsai changed the title [WIP] add oneDNN and oneCCL samples add oneDNN and oneCCL samples Aug 20, 2020
samples-ci
samples-ci previously approved these changes Aug 21, 2020
View reviewed changes
Copy link

@samples-ci samples-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggering CI. Will wait for @sravanikonda 's approval before merging.

anjgola
anjgola previously approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@anjgola anjgola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

triggering CI with my correct account. Will wait @sravanikonda 's approval before merging.

@louie-tsai louie-tsai dismissed stale reviews from anjgola and samples-ci via d664fb5 August 21, 2020 16:28
@louie-tsai
Copy link
Contributor Author

@sravanikonda
fixed it according to your input.

anjgola
anjgola previously approved these changes Aug 22, 2020
View reviewed changes
Copy link
Contributor

@anjgola anjgola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggering CI

mkitez
mkitez previously approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@mkitez mkitez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to run CI.
@louie-tsai please review failure details for the simple_model application. It looks like the resulting binary is not found.

mkitez
mkitez reviewed Aug 24, 2020
View reviewed changes
Libraries/oneCCL/oneCCL_Getting_Started/sample.json
"cmake .. -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=dpcpp",
"make",
"mpirun -n 2 ./out/sycl/sycl_allreduce_cpp_test cpu",
"mpirun -n 2 ./out/sycl/sycl_allreduce_cpp_test gpu"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test should be split into 2 configurations, one for CPU the other one for GPU. Same for all other samples.

@JoeOster
Copy link
Contributor

@pmpeter1 - can you please approve if appropriate

pmpeter1
pmpeter1 approved these changes Aug 24, 2020
View reviewed changes
Copy link

@pmpeter1 pmpeter1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to follow a consistent coding style.

@JoeOster JoeOster merged commit e5ec85a into oneapi-src:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmpeter1 pmpeter1 pmpeter1 approved these changes

@sravanikonda sravanikonda sravanikonda approved these changes

@JoeOster JoeOster JoeOster approved these changes

@samples-ci samples-ci samples-ci left review comments

@praveenkk123 praveenkk123 Awaiting requested review from praveenkk123

+2 more reviewers

@mkitez mkitez mkitez left review comments

@anjgola anjgola anjgola left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@louie-tsai @anjgola @JoeOster @pmpeter1 @mkitez @sravanikonda @samples-ci