-
Notifications
You must be signed in to change notification settings - Fork 734
Update README.md #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #24
Conversation
Can we put this as third-party-programs.txt file instead of README. We need to put other landing page information in README. |
@@ -0,0 +1,52 @@ | |||
//============================================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we committing this file here? Isn't it supposed to be inside oneAPI package only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per request by Swapna, it is for reference only.
@@ -1,2 +1,2 @@ | |||
# oneAPI-samples | |||
oneAPI-samples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you are changing header to a paragraph, is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a place holder, we are working on a readme, so do not approve the merge as of yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As long as CI would not be affected by introducing the 'common' folder, we can go ahead and merge.
No description provided.