Skip to content

Conversation

JoeOster
Copy link
Contributor

No description provided.

@JoeOster JoeOster requested review from anjgola and mkitez as code owners July 13, 2020 23:19
@anjgola
Copy link
Contributor

anjgola commented Jul 14, 2020

Can we put this as third-party-programs.txt file instead of README. We need to put other landing page information in README.

@@ -0,0 +1,52 @@
//==============================================================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we committing this file here? Isn't it supposed to be inside oneAPI package only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per request by Swapna, it is for reference only.

@@ -1,2 +1,2 @@
# oneAPI-samples
oneAPI-samples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you are changing header to a paragraph, is this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a place holder, we are working on a readme, so do not approve the merge as of yet

Copy link
Contributor

@anjgola anjgola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As long as CI would not be affected by introducing the 'common' folder, we can go ahead and merge.

@JoeOster JoeOster merged commit 139c49e into master Jul 15, 2020
@JoeOster JoeOster deleted the Update-third-Party branch July 21, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants