Add AWS IoT Code Sample #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey4latyshev
requested review from
JoeOster,
anjgola and
mkitez
as code owners
anjgola
added
PendingWGApproval
anjgola
reviewed
Jul 28, 2020
| @@ -0,0 +1,61 @@ | |||
| # Contributing Guidelines | |||
There was a problem hiding this comment.
This file is not releveant to our repo, please remove it. This repo has its own contributing guideline.
| @@ -0,0 +1,4 @@ | |||
| ## Code of Conduct | |||
| This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct). | |||
| For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact | |||
There was a problem hiding this comment.
This file is not releveant to our repo, please remove it. This repo has its own contributing guideline.
JoeOster
requested changes
Jul 29, 2020
There was a problem hiding this comment.
A few things on this one
- license file should be License.txt for consistency across all samples, .txt extensions is also used by CI
- read me is in an old style, take a look at: : https://gitlab.devtools.intel.com/ecosystem-dev-programs/pre-release/intel-oneapi-sample-template/blob/master/README.md
- samples.json should prove compile at a minimum
- sample.json file is also not validating running the app, but suspect a open port is needed. Please confirm thats the case
JoeOster
previously approved these changes
Aug 4, 2020
|
Please add ciTests field. |
mkitez
previously approved these changes
Aug 5, 2020
JoeOster
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sample to test AWS Basic Pub Sub sample.