IBM IoT sample #13
IBM IoT sample #13
Conversation
|
@mkitez interesting case to observe here. Checks passed for missing sample.json, I guess it could be that the sample does not require sample.json but I think we should fail the CI and let it be an explicit override by maintainer to merge this sample. Something to think about, doesn't affect this MR since Andrey plans to enter a sample.json and had marked this request as WIP. |
anjgola
added
PendingWGApproval
There was a problem hiding this comment.
Couple of Issues that I noticed right off
- no licenses.txt file,
- samples.json should prove compile at a minimum
- sample.json file is also not validating running the app, but suspect a open port is needed. Please confirm thats the case
- read me is in a old style, take a look at: : https://gitlab.devtools.intel.com/ecosystem-dev-programs/pre-release/intel-oneapi-sample-template/blob/master/README.md
|
@andrey4latyshev - Please take a look at and resolve the CI error, error message is below |
| make | ||
| sudo make -C paho.mqtt.c install | ||
| sudo make install | ||
| ``` |
There was a problem hiding this comment.
Are these instructions applicable anymore?
There was a problem hiding this comment.
Are these instructions applicable anymore?
@andrey4latyshev - can you take a look at this
There was a problem hiding this comment.
Yes, these instructions help to build prerequisites.
There was a problem hiding this comment.
Why ask them to git clone the sample from that repo when it is present in this repo?
There was a problem hiding this comment.
Why ask them to git clone the sample from that repo when it is present in this repo?
This step is needed to clone the dependency library IBM Watson IoT Platform from git.
|
We have OS PDT and legal approval for the IBM Watson IoT Platform SDK. Ok from my side. Thanks. |
A sample to test IBM device connection. It is not approved by Sample Workgroup yet so marked as WIP.