Skip to content

Conversation

ethanhirsch
Copy link
Contributor

Description

Added a SIMD dot product function to the intrinsics sample as per github issue: #63

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Command Line

ethanhirsch and others added 13 commits July 9, 2020 10:27
Merging base repo master into my master
Merging origin master changes to my master
Merge latest changes from oneAPI-src
Updating personal fork with oneAPI-src
Signed-off-by: Ethan Hirsch <[email protected]>
Signed-off-by: Ethan Hirsch <[email protected]>
Signed-off-by: Ethan Hirsch <[email protected]>
Signed-off-by: Ethan Hirsch <[email protected]>
Signed-off-by: Ethan Hirsch <[email protected]>
Signed-off-by: Ethan Hirsch <[email protected]>
@JoeOster JoeOster linked an issue Aug 24, 2020 that may be closed by this pull request
@JoeOster JoeOster requested review from JoeOster, a team, mkitez and srdontha and removed request for a team August 24, 2020 22:43
JoeOster
JoeOster previously approved these changes Aug 24, 2020
srdontha
srdontha previously approved these changes Aug 24, 2020
@srdontha srdontha requested a review from pmpeter1 August 24, 2020 22:52
@srdontha
Copy link

@pmpeter1 Requesting your review as this is linked to an external request.

Copy link

@pmpeter1 pmpeter1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should follow the parts of the coding guidelines that are applicable to OpenMP.

@anjgola anjgola requested a review from a team August 25, 2020 00:35
@ethanhirsch ethanhirsch dismissed stale reviews from srdontha and JoeOster via 9a75101 August 25, 2020 16:39
@ethanhirsch ethanhirsch requested a review from pmpeter1 August 25, 2020 17:12
@JoeOster
Copy link
Contributor

Should follow the parts of the coding guidelines that are applicable to OpenMP.

Ethan fixed the sample, by using clang

@JoeOster JoeOster merged commit 3336c22 into oneapi-src:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature update for intrin_dot_sample.cpp
5 participants