Add vtune and advisor sample #102
Conversation
Signed-off-by: kevin.p.oleary <[email protected]>
Signed-off-by: kevin.p.oleary <[email protected]>
anjgola
requested review from
a team,
praveenkk123,
sravanikonda,
akertesz and
JoeOster
and removed request for
a team
Tools/Advisor/matrix_multiply_advisor/Advisor_matrix_multiply_advisor_README.md
Outdated
Show resolved
Hide resolved
| // ============================================================= | ||
|
|
||
| #include <malloc.h> | ||
| #include <chrono> |
There was a problem hiding this comment.
chrono should not be used, please use /common/dpc_common.hpp for timing
When you do this, please include the following in the readme
// dpc_common.hpp can be found in the dev-utilities include folder.
// e.g., $ONEAPI_ROOT/dev-utilities//include/dpc_common.hpp
#include "dpc_common.hpp"
|
I believed I have resolved all of the issues from this pull requet |
| #include <malloc.h> | ||
| #include <iostream> | ||
|
|
||
| #include "dpc_common.hpp" |
There was a problem hiding this comment.
Please add the comments below for for the include of dpc_common.hp. it should look like this:
// dpc_common.hpp can be found in the dev-utilities include folder.
// e.g., $ONEAPI_ROOT/dev-utilities//include/dpc_common.hpp
#include "dpc_common.hpp"
| ## License | ||
| This code sample is licensed under MIT license | ||
|
|
||
| ## How to Build |
There was a problem hiding this comment.
Please add a comment to Readme in regards to the location of dpc_common.hpp, should look similar to this:
Building the Program for CPU and GPU
Include Files
The include folder is located at %ONEAPI_ROOT%\dev-utilities\latest\include on your development system.
|
|
||
| ## Running the Sample | ||
|
|
||
| ### Example of Output |
There was a problem hiding this comment.
When you view this file, the out put for the "example of output" is incorrectly formatted"
|
Joe... I believe I resolved all of your comments |
Description
I followed the instructions to copy from gitlab