Update Usage in README.md #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okonet
requested changes
Jan 25, 2021
Owner
okonet
left a comment
okonet
left a comment
There was a problem hiding this comment.
I don't think it's correct. The example uses a class component but you replaced render method to return without updating the rest of it.
Author
|
Then you need to check about |
Owner
|
Sorry I don't understand that. Maybe it is better to drop those examples for good since we have working examples in the styleguide? |
Author
|
If you think it's better, do it. |
Owner
|
Well, you reported an issue so I'd expect you to finish it. I'd be also interested in what you think would be better for developers like you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an error while executing an usage of a README.md. And I found what the problem is. It would be helpful to reflect this in the document.