[FIX] account : compute invoice_partner_bank_id when computing bank_partner_id #92660

abla001 · 2022-06-01T13:37:38Z

To reproduce

add a bank account to MyCompany
create contact who has a bank account
create customer invoice for this contact
create credit note from this invoice

the Bank Account of the credit note is set to MyCompany's bank account, where it should be
the customer's account

Purpose

when creating the credit note we don't set the field invoice_partner_bank_id

Specification

to solve the issue we compute the field invoice_partner_bank_id when computing the field bank_partner_id

opw-2862601

robodoo · 2022-06-01T13:38:33Z

agr-odoo

Duplicate of #85982 for v13
@Levizar

agr-odoo · 2022-06-02T06:40:38Z

addons/account/models/account_move.py

To avoid multicompany issue you could should add a check on the bank company_id
move.bank_partner_id.filtered(lambda bank: bank.company_id.id in (False, move.company_id.id))

@agr-odoo I updated the commit, thank you 🙏

jco-odoo · 2022-06-03T08:16:20Z

addons/account/models/account_move.py

There is a problem here as I am not usre invoice_partner_bank_id is a computed field and you do not depend on the company_id/journal_id in the api.depends. @abla001

Indeed, because these are 2 stored computed fields, you need to compute them in two different functions

william-andre

Like seen in this PR #85982, the field was wrongly "manually" computed at some places, instead of computing it correctly in those places, you should remove the fact that it is set explicitly to a possible wrong value.

william-andre · 2022-06-03T08:13:33Z

addons/account/models/account_move.py

Don't compute fields that are not supposed to be computed

Don't change it if it was already a valid bank

You can also use filtred_bank_partner_id.bank_ids[:1] to take the first record safely

filtered

william-andre · 2022-06-03T08:19:40Z

addons/account/models/account_move.py

Indeed, because these are 2 stored computed fields, you need to compute them in two different functions

william-andre · 2022-06-03T08:23:46Z

Also, the commit message can be more explicit on who the invoice is directed at . To a customer or a vendor? Because these have opposite behaviors in the matter you are fixing.

abla001 · 2022-06-03T09:35:26Z

@jco-odoo, @william-andre, thank you so much for the feedback, I updated the commit 🙏

william-andre

Runbot is red, please also check account.payment.register._get_line_batch_key (#85982)

william-andre · 2022-06-03T10:51:31Z

addons/account/models/account_move.py

Lets keep related arguments together, and lets reduce the amount of lines modified

Suggested change

invoice_partner_bank_id = fields.Many2one('res.partner.bank', string='Bank Account', store=True, readonly=False,

compute="_compute_invoice_partner_bank_id",

invoice_partner_bank_id = fields.Many2one('res.partner.bank', string='Bank Account',

compute="_compute_invoice_partner_bank_id", store=True, readonly=False,

william-andre · 2022-06-03T10:55:09Z

addons/account/models/account_move.py

Suggested change

filtred_bank_partner_id = move.bank_partner_id.filtered(lambda bank: bank.company_id.id in (False, move.company_id.id))

move.invoice_partner_bank_id = filtred_bank_partner_id.bank_ids[:1]

filtered_bank_partner_id = move.bank_partner_id.filtered(lambda bank: bank.company_id.id in (False, move.company_id.id))

move.invoice_partner_bank_id = filtered_bank_partner_id.bank_ids[:1]

nle-odoo · 2022-06-09T09:08:38Z

for current red runbot, this is happening because we are writing on invoice_partner_bank_id:

odoo/addons/account/models/account_move.py

Line 2590 in 550f9e7

    
           move.write({'invoice_line_ids' : [(5, 0, 0)], 'invoice_partner_bank_id': False})

but lines are also written at the same time and they will trigger a recompute of invoice_partner_bank_id but the field invoice_partner_bank_id is protected (since we are writing on it), so if the write on line_ids happens before the write on invoice_partner_bank_id we don't recompute it and there is a CacheMiss error.

an example of a fix (a little hacky) would be to do:

+ invoice.invoice_partner_bank_id # just used so the field is in cache when recomputed before it is written
  move.write({'invoice_line_ids' : [(5, 0, 0)], 'invoice_partner_bank_id': False})

william-andre · 2022-06-09T09:52:45Z

addons/account/models/account_move.py

I'm not sure what triggers the recompute
invoice_partner_bank_id is triggered by bank_partner_id
And bank_partner_id is triggered by commercial_partner_id,
Then commercial_partner_id is triggered by partner_id, which doesn't depend on invoice_line_ids or invoice_partner_bank_id

If the issue is that the field is protected because it is recomputed, wouldn't the solution be to not set the field to False in the first place?

setting invoice_partner_bank_id to False was added in this fix : 564c4f5

I'm afraid that removing breaks that fix.

the field is protected because we are writing on it:

odoo/odoo/models.py

Lines 3559 to 3570 in 550f9e7

if field.inverse or (field.compute and not field.readonly):

if field.store or field.type not in ('one2many', 'many2many'):

# Protect the field from being recomputed while being

# inversed. In the case of non-stored x2many fields, the

# field's value may contain unexpeced new records (created

# by command 0). Those new records are necessary for

# inversing the field, but should no longer appear if the

# field is recomputed afterwards. Not protecting the field

# will automatically invalidate the field from the cache,

# forcing its value to be recomputed once dependencies are

# up-to-date.

protected.update(self._field_computed.get(field, [field]))

but before we do the field write on invoice_partner_bank_id, we do the field write on 'line_ids' that is causing an account.move.line().unlink() that is causing a flush of everything and a recompute of everything.

edit: another solution (without ORM change) would be to do .invoice_partner_bank_id = False after writing on the lines, from the linked commit this seemed to be the intention.

I'm afraid that removing breaks that fix.

It wouldn't break the fix if the compute function is called again...

the field is protected because we are writing on it:

Yes, that I know

that is causing a flush of everything and a recompute of everything.

AFAIK, stored fields should not be recomputed unless triggered by a field change. I don't see what would trigger it.

My understanding with your hack is that indeed you cache the old value, but that value is the wrong one, and we would get back to the behavior before 564c4f5

@william-andre , I applied your suggestion, I tested and you were right, removing False doesn't break the old fix, thank you 🙏

william-andre

Final touch to be sure

william-andre · 2022-06-10T13:55:33Z

addons/account/models/account_move.py

Can you add the type in here to be sure that the bank_partner_id is recomputed here
https://github.com/odoo/odoo/blob/c07f3560d7b9c23b6a2bbb74363670e517c75951/addons/account/models/account_move.py#L2581

To ensure that invoice_partner_bank_id is recomputed too

…artner_id To reproduce ============ - add a bank account to *MyCompany* - create contact who has a bank account - create customer invoice for this contact - create credit note from this invoice the Bank Account of the credit note is set to *MyCompany's* bank account, where it should be the customer's account Purpose ======= when creating the credit note we don't set the field `invoice_partner_bank_id` Specification ============= to solve the issue we compute the field `invoice_partner_bank_id` when computing the field `bank_partner_id` opw-2862601

abla001 · 2022-06-13T07:42:07Z

@william-andre, I applied your suggestion, thank you and @nle-odoo for the follow-up 🙏

william-andre

@robodoo r+

…artner_id To reproduce ============ - add a bank account to *MyCompany* - create contact who has a bank account - create customer invoice for this contact - create credit note from this invoice the Bank Account of the credit note is set to *MyCompany's* bank account, where it should be the customer's account Purpose ======= when creating the credit note we don't set the field `invoice_partner_bank_id` Specification ============= to solve the issue we compute the field `invoice_partner_bank_id` when computing the field `bank_partner_id` opw-2862601 closes #92660 Signed-off-by: William André (wan) <[email protected]>

fw-bot · 2022-06-17T05:53:30Z

This pull request has forward-port PRs awaiting action (not merged or closed): #93467

fw-bot · 2022-06-18T05:54:30Z

This pull request has forward-port PRs awaiting action (not merged or closed): #93467

fw-bot · 2022-06-19T05:53:18Z

This pull request has forward-port PRs awaiting action (not merged or closed): #93467

fw-bot · 2022-06-20T05:53:44Z

This pull request has forward-port PRs awaiting action (not merged or closed): #93467

fw-bot · 2022-06-21T05:53:45Z

This pull request has forward-port PRs awaiting action (not merged or closed): #93467

fw-bot · 2022-06-22T05:53:02Z

This pull request has forward-port PRs awaiting action (not merged or closed): #94152

fw-bot · 2022-06-23T05:53:19Z

This pull request has forward-port PRs awaiting action (not merged or closed): #94152

fw-bot · 2022-06-25T05:53:13Z

This pull request has forward-port PRs awaiting action (not merged or closed): #94152

fw-bot · 2022-07-03T05:53:05Z

This pull request has forward-port PRs awaiting action (not merged or closed): #94152

…artner_id To reproduce ============ - add a bank account to *MyCompany* - create contact who has a bank account - create customer invoice for this contact - create credit note from this invoice the Bank Account of the credit note is set to *MyCompany's* bank account, where it should be the customer's account Purpose ======= when creating the credit note we don't set the field `invoice_partner_bank_id` Specification ============= to solve the issue we compute the field `invoice_partner_bank_id` when computing the field `bank_partner_id` opw-2862601 closes odoo#92660 Signed-off-by: William André (wan) <[email protected]>

fw-bot · 2022-07-19T05:53:14Z

This pull request has forward-port PRs awaiting action (not merged or closed): #94152

…artner_id To reproduce ============ - add a bank account to *MyCompany* - create contact who has a bank account - create customer invoice for this contact - create credit note from this invoice the Bank Account of the credit note is set to *MyCompany's* bank account, where it should be the customer's account Purpose ======= when creating the credit note we don't set the field `invoice_partner_bank_id` Specification ============= to solve the issue we compute the field `invoice_partner_bank_id` when computing the field `bank_partner_id` opw-2862601 closes odoo/odoo#92660 Signed-off-by: William André (wan) <[email protected]>

C3POdoo added the OE the report is linked to a support ticket (opw-...) label Jun 1, 2022

agr-odoo reviewed Jun 2, 2022

View reviewed changes

abla001 force-pushed the 13.0-opw-2862601-set_bank_account_credit_note-abla branch from 5a198fd to f288669 Compare June 2, 2022 08:46

jco-odoo reviewed Jun 3, 2022

View reviewed changes

william-andre requested changes Jun 3, 2022

View reviewed changes

abla001 force-pushed the 13.0-opw-2862601-set_bank_account_credit_note-abla branch from f288669 to 6a7542b Compare June 3, 2022 09:33

abla001 marked this pull request as ready for review June 3, 2022 09:34

C3POdoo requested review from a team and epictete and removed request for a team June 3, 2022 09:35

abla001 force-pushed the 13.0-opw-2862601-set_bank_account_credit_note-abla branch 2 times, most recently from 49ae196 to 4d827cb Compare June 3, 2022 10:26

william-andre reviewed Jun 3, 2022

View reviewed changes

abla001 force-pushed the 13.0-opw-2862601-set_bank_account_credit_note-abla branch from 4d827cb to ec9a347 Compare June 9, 2022 09:22

william-andre reviewed Jun 9, 2022

View reviewed changes

abla001 force-pushed the 13.0-opw-2862601-set_bank_account_credit_note-abla branch 2 times, most recently from d5d2b2c to c07f356 Compare June 10, 2022 10:46

william-andre reviewed Jun 10, 2022

View reviewed changes

abla001 force-pushed the 13.0-opw-2862601-set_bank_account_credit_note-abla branch from c07f356 to f4bf833 Compare June 10, 2022 14:09

william-andre approved these changes Jun 13, 2022

View reviewed changes

robodoo closed this Jun 13, 2022

robodoo temporarily deployed to merge June 13, 2022 13:55 Inactive

fw-bot mentioned this pull request Jun 13, 2022

[FW][FIX] account : compute invoice_partner_bank_id when computing bank_partner_id #93467

Closed

fw-bot mentioned this pull request Jun 21, 2022

[FW][FIX] account : compute invoice_partner_bank_id when computing bank_partner_id #94152

Closed

fw-bot deleted the 13.0-opw-2862601-set_bank_account_credit_note-abla branch June 27, 2022 14:46

-    invoice_partner_bank_id = fields.Many2one('res.partner.bank', string='Bank Account', store=True, readonly=False,
-        compute="_compute_invoice_partner_bank_id",
+    invoice_partner_bank_id = fields.Many2one('res.partner.bank', string='Bank Account',
+        compute="_compute_invoice_partner_bank_id", store=True, readonly=False,

-            filtred_bank_partner_id = move.bank_partner_id.filtered(lambda bank: bank.company_id.id in (False, move.company_id.id))
-            move.invoice_partner_bank_id = filtred_bank_partner_id.bank_ids[:1]
+            filtered_bank_partner_id = move.bank_partner_id.filtered(lambda bank: bank.company_id.id in (False, move.company_id.id))
+            move.invoice_partner_bank_id = filtered_bank_partner_id.bank_ids[:1]

	if field.inverse or (field.compute and not field.readonly):
	if field.store or field.type not in ('one2many', 'many2many'):
	# Protect the field from being recomputed while being
	# inversed. In the case of non-stored x2many fields, the
	# field's value may contain unexpeced new records (created
	# by command 0). Those new records are necessary for
	# inversing the field, but should no longer appear if the
	# field is recomputed afterwards. Not protecting the field
	# will automatically invalidate the field from the cache,
	# forcing its value to be recomputed once dependencies are
	# up-to-date.
	protected.update(self._field_computed.get(field, [field]))

[FIX] account : compute invoice_partner_bank_id when computing bank_partner_id #92660

[FIX] account : compute invoice_partner_bank_id when computing bank_partner_id #92660

Uh oh!

Conversation

abla001 commented Jun 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

To reproduce

Purpose

Specification

Uh oh!

robodoo commented Jun 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agr-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jco-odoo Jun 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

william-andre left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

william-andre commented Jun 3, 2022

Uh oh!

abla001 commented Jun 3, 2022

Uh oh!

william-andre left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nle-odoo commented Jun 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abla001 Jun 9, 2022 • edited by nle-odoo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nle-odoo Jun 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

william-andre left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abla001 commented Jun 13, 2022

Uh oh!

william-andre left a comment

Choose a reason for hiding this comment

Uh oh!

fw-bot commented Jun 17, 2022

Uh oh!

fw-bot commented Jun 18, 2022

Uh oh!

fw-bot commented Jun 19, 2022

Uh oh!

fw-bot commented Jun 20, 2022

Uh oh!

fw-bot commented Jun 21, 2022

abla001 commented Jun 1, 2022 •

edited

Loading

robodoo commented Jun 1, 2022 •

edited

Loading

jco-odoo Jun 3, 2022 •

edited

Loading

nle-odoo commented Jun 9, 2022 •

edited

Loading

abla001 Jun 9, 2022 •

edited by nle-odoo

Loading

nle-odoo Jun 9, 2022 •

edited

Loading