[FIX] mrp: update the “stock.move” name after the MO creation

[DjamelTouati]

Steps to reproduce the bug:

• Create a storable product “P1” with BOM:

  • component: 1 unit of “C1”
  • Consumption: Flexible

• Create a MO to produce one “P1”:

  • Click on “Mark as todo”
  • Click on “produce”
  • In the window that opens, add one unit of "C1" in new line
  • Confirm the MO

• Go to the product form of “C1”:

  • Click on the traceability button

Problem:
The stock.move for the additional unit component(not initially planned in the Bill of materials)
is with reference “New” instead of the MO name

Bug:
The first stock.move will be created with the name New and after the MO creation,
its reference will be updated but not its name:

odoo/addons/mrp/models/mrp_production.py

Lines 504 to 508 in 13241c7

	production = super(MrpProduction, self).create(values)
	production.move_raw_ids.write({
	'group_id': production.procurement_group_id.id,
	'reference': production.name, # set reference when MO name is different than 'New'
	})

So when an additional unit of the component will be added, the _create_extra_move
function will be called, therefore a copy of the first stock.move will be made:
https://github.com/odoo/odoo/blob/13.0/addons/stock/models/stock_move.py#L1371

But as its name is new the new stock.move will have the same name
and its reference will be calculated based on the name:

odoo/addons/stock/models/stock_move.py

Lines 212 to 215 in 0b9105c

	@api.depends('picking_id', 'name')
	def _compute_reference(self):
	for move in self:
	move.reference = move.picking_id.name if move.picking_id else move.name

opw-2839202

bug_traceability.mp4

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[robodoo]

[amoyaux]

robodoo r+

[amoyaux]

Suggested change

	prod_move = self.filtered(lambda m: m.raw_material_production_id)
	for move in prod_move:
	move.write({
	'name': move.raw_material_production_id.name,
	'reference': move.raw_material_production_id.name,
	})
	super(StockMove, self - prod_move)._compute_reference()
	not_prod_move = set()
	for move in self:
	if not move.raw_material_production_id:
	not_prod_move.add(move.id)
	continue
	move.write({
	'name': move.raw_material_production_id.name,
	'reference': move.raw_material_production_id.name,
	})
	super(StockMove, self.browse(not_prod_move))._compute_reference()

Always good to avoid an extra loop

[DjamelTouati]

Done, thanks! But I think it's better to use an empty recordset to avoid doing a browse when calling the super, what do you think ?

[DjamelTouati]

@robodoo r-

[DjamelTouati]

Hello @amoyaux
Do you think we can r+ this PR?

[amoyaux]

robodoo r+