[IMP] web: update javascript odoo modules #7640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aab-odoo
reviewed
Feb 5, 2024
mcm-odoo
force-pushed
the
master-odoo-module-ignore-mcm
branch
2 times, most recently
from
17a326c to
bf94c2f
Compare
aab-odoo
reviewed
Feb 5, 2024
Contributor
There was a problem hiding this comment.
I think we can improve again :-)
Here's how I see it:
- intro (we use native modules, simpler, IDE...)
- but we transpile everything in src and tests in odoo modules -> exemple de code transpilé
- can be disabled with odoo-module ignore (odoo will check first line blablabla)
- in other folders, no transpiler by default, can be enable with odoo-module
fdardenne
reviewed
Feb 5, 2024
Contributor
There was a problem hiding this comment.
Hello, thank you for the PR!
Can we take advantage of this PR to reflect the changes in the tutorial ?
- There is a odoo-module here
documentation/content/developer/tutorials/master_odoo_web_framework/02_create_gallery_view.rst L212 - The warning should not be useful anymore
documentation/content/developer/tutorials/discover_js_framework/01_owl_components.rstL125
mcm-odoo
force-pushed
the
master-odoo-module-ignore-mcm
branch
from
bf94c2f to
ef3e8c8
Compare
C3POdoo
requested review from
a team,
HydrionBurst and
xmo-odoo
and removed request for
a team
AntoineVDV
approved these changes
Feb 5, 2024
Collaborator
AntoineVDV
left a comment
AntoineVDV
left a comment
There was a problem hiding this comment.
Nice!
@robodoo delegate+
mcm-odoo
changed the title
mcm-odoo
force-pushed
the
master-odoo-module-ignore-mcm
branch
2 times, most recently
from
1601abe to
438ba77
Compare
Collaborator
|
I'm sorry, @aab-odoo. I'm afraid I can't do that. |
aab-odoo
reviewed
Feb 6, 2024
This commit adapts the javascript modules section with the last update odoo/odoo#142858 and some outdated features.
mcm-odoo
force-pushed
the
master-odoo-module-ignore-mcm
branch
from
438ba77 to
ba773cb
Compare
Contributor
Author
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 6, 2024
This commit adapts the javascript modules section with the last update odoo/odoo#142858 and some outdated features. closes #7640 Signed-off-by: Michaël Mattiello (mcm) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adapts the javascript modules section with the last update odoo/odoo#142858 and some outdated features.