Skip to content

Conversation

@tiku-odoo
Copy link
Contributor

@robodoo
Copy link
Collaborator

robodoo commented Jan 17, 2024

@tiku-odoo tiku-odoo requested a review from lse-odoo January 17, 2024 22:32
@C3POdoo C3POdoo requested a review from a team January 17, 2024 22:32
@tiku-odoo
Copy link
Contributor Author

@lse-odoo

Hi Loan,
Can you review this doc when you have a chance? Just added some additional information per:

#7251

@lse-odoo
Copy link
Contributor

@tiku-odoo I am not sure of the behavior in version < 17.0, I guess it would be better to ask to the functional support the intended behavior in this versions :/

@tiku-odoo tiku-odoo requested a review from wigu-odoo January 18, 2024 13:28
@tiku-odoo
Copy link
Contributor Author

@wigu-odoo

Can you review this doc when you have a moment?

@wigu-odoo
Copy link

Hello @tiku-odoo

I will test again on Monday when I am back in the office (thanks snowstorms) but it does look mostly correct!

The one thing I did notice from when I tested this about a month ago in a ticket that I needed to escalate was that the popup to select printer does not appear unless I have developer mode active.

In the ticket I have a video from runbot when I have dev mode enabled as well as a screenshot from runbot and in the screenshot, I do not get the popup since I don't have developer mode enabled, but in my recording, I do when I have developer mode enabled.

The debug icon is also present in my recording with this popup.

I am pretty sure developer mode needs to be enabled for the popup to select the printer, but I will test more when I am in the office on Monday to confirm.

@lse-odoo
Copy link
Contributor

@wigu-odoo if I am not mistaken, the pop-up show once then save into the browser cookie your result. So maybe the fact to switch to developer mode is not true and made you think that it was needed

@wigu-odoo
Copy link

@lse-odoo You were indeed correct, developer mode is not necessary for the popup.

@tiku-odoo this is indeed correct!

Copy link

@wigu-odoo wigu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just tested to be sure developer mode is not necessary, everything looks correct!

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants