-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[ADD] Upgrade documentation: Migration scripts and Util package #7330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e6a17c0 to
ab15cfe
Compare
4e93643 to
0158404
Compare
18b0057 to
2b68d58
Compare
|
Please don't call them |
4f7e363 to
a680bac
Compare
|
I think you should add a section somewhere to describe how to use the upload script (via Python). Upgrade support team answer the same questions again and again in tickets. A recent one: using |
|
Hey @aj-fuentes IMO, it could be a good idea to create a "Frequently Asked Questions" page for upgrade where we can answer those kind of questions and how to solve recurrent issues. Please, if you have any suggestions or ideas on the structure or the questions/topics to include, don't hesitate to let me know |
Feyensv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a fixup commit with suggestions/improvements ;)
Feel free to see if everything's ok for you and squash the commits.
| Phases of upgrade scripts | ||
| ========================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phases ? wouldn't steps be more understandable/clear ? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, the odoo/upgrade wiki mentions "steps".
d24a939 to
e513911
Compare
AntoineVDV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, it's nice to see progress on the documentation of the upgrade-util repo 👍
Content-wise, I think we're good. I have made a few nitpicking comments, but that's it.
However, I think we can come up with a better structure for the new content. Indeed, in the documentation, we try as much as possible to organize the structure according to the type of content: tutorials, how-to guides, and reference pages where it makes sense. It helps keep the information discoverable and allows the user to get to it faster.
Here, the valuable reference on the upgrade-util repository is "buried" inside the "Upgrade a customized database" how-to guide, which not many R&D developers at Odoo will browse out of curiosity. Also, the content of the "Upgrade scripts" page is a mix of how-to instructions (e.g., "create this and that files", "upgrade like this on Odoo.sh") and reference statements (e.g., migrate signature, the structure of the migrations directory, the steps of the upgrade) that is oriented on only the custom module upgrade use-case, while it could be made more generic and also explain how upgrades work on the odoo/upgrade repository.
Please consider making the minor changes below that should help restructure the new content:
- Move the
upgrade_utilpage to/developer/reference/upgrade_util. I'd say before "External API". - Extract the reference-oriented content of the
upgrade_scriptspage to that new reference page. Namely:- The
migratesignature. - The structure of the
migrationsdirectory, with the content rephrased to be statements rather than steps: "The path to the script should be in the formatsomething/something/etc, where: -migrationsis that, -<version>is this, etc. - The steps of the upgrade, in the same tone as above.
- The
- Extract the how-to-oriented content of the
upgrade_scriptspage to the parent "Upgrade a customized database" page. That should be only the "Running and testing upgrade scripts" section. - Delete the two pages under
upgrade_custom_db. - Make a pass on the reference documentation to make sure it is compatible with the "standard upgrade" (
odoo/upgrade) flow.
Tell me what you think, or feel free to reach out for a discussion about that ;)
d9b169f to
d51340a
Compare
|
Hello @AntoineVDV , Thanks for the comments and suggestions! Regarding the missing ones:
|
|
As discussed, let's keep the best of both worlds: whatever is generic enough goes to the reference page; what is specific to custom upgrade stays in the how-to, without a counterpart for the odoo/upgrade repo. |
d51340a to
2e74ea8
Compare
2e74ea8 to
389c0a1
Compare
AntoineVDV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
closes #7330 Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
Continuation or #6757
In this PR we add more technical information on the Upgrade Process: