[IMP] Studio: new report editor #6948
Conversation
auva-odoo
force-pushed
the
saas-16.4-report-editor-auva
branch
4 times, most recently
from
f799c25 to
9366b30
Compare
auva-odoo
force-pushed
the
saas-16.4-report-editor-auva
branch
3 times, most recently
from
5eec757 to
9dbbe58
Compare
auva-odoo
requested review from
bouvyd and
zulu-odoo
and removed request for
a team
zulu-odoo
left a comment
zulu-odoo
left a comment
There was a problem hiding this comment.
Hi Audrey,
Please see my comments, I hope they're helpful. As always, feel free to ignore whatever you disagree with :) And let me know if you want to go through them together.
I tried playing a bit with the XML code but I didn't get very far tbh, but since those come from the PO, I think it's fine.
auva-odoo
force-pushed
the
saas-16.4-report-editor-auva
branch
2 times, most recently
from
809939f to
7bdd29f
Compare
|
Hello @zulu-odoo, thank you for your review :) I made some more additional changes, could you please review them? Especially lines 169-244. I'm still not 100% convinced I think but I don't know how else I could structure it :( |
zulu-odoo
left a comment
zulu-odoo
left a comment
There was a problem hiding this comment.
RIEN A DIRE, 10/10, very clear and all changes make sense.
bouvyd
left a comment
bouvyd
left a comment
There was a problem hiding this comment.
LGTM, thx for the improvement!
xpl-odoo
left a comment
xpl-odoo
left a comment
There was a problem hiding this comment.
Great job, I just spotted some minor improvements :)
task-3553091
auva-odoo
force-pushed
the
saas-16.4-report-editor-auva
branch
from
7bdd29f to
2003341
Compare
|
@robodoo r+ |
task-3553091 closes #6948 Signed-off-by: Audrey Vandromme (auva) <[email protected]>
task-3553091