Skip to content

Conversation

@ksc-odoo
Copy link
Contributor

@ksc-odoo ksc-odoo commented Dec 6, 2023

@ksc-odoo ksc-odoo self-assigned this Dec 6, 2023
@robodoo
Copy link
Collaborator

robodoo commented Dec 6, 2023

@C3POdoo C3POdoo requested a review from a team December 6, 2023 21:05
@ksc-odoo ksc-odoo force-pushed the 17.0-subscriptions-update-upsell-ksc branch from a57ba1c to e181019 Compare December 6, 2023 21:10
@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented Dec 6, 2023

Hey @meng-odoo this one's ready for its first round of Peer Review! 👍

@ksc-odoo ksc-odoo requested a review from meng-odoo December 6, 2023 21:12
Copy link
Contributor

@jero-odoo jero-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksc-odoo just a few small changes, approving and sending on to @samueljlieber for tech/final review 👍

@ksc-odoo ksc-odoo force-pushed the 17.0-subscriptions-update-upsell-ksc branch from e181019 to b6814f4 Compare December 28, 2023 21:20
@ksc-odoo
Copy link
Contributor Author

Thanks for the feedback @jero-odoo -- I made those minor adjustments, so it's ready for your Technical Review skills/expertise now, @samueljlieber 👍

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo, nice job with the improvements in this PR! I will push up a commit to fix this one correction. Thank you!

Comment on lines 11 to 14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksc-odoo if you want to format a line break, use | at the start of the line and then indent a space for any lines that you want to wrap normally under the first line 🙂

Suggested change
#. *Loyal Customers*
These are customers who already trust the company/brand, and because they have established a
pattern of paying for products/services, there's more confidence behind the attempt to sell them
a more expensive product/service.
#. | *Loyal Customers*
| These are customers who already trust the company/brand, and because they have established a
pattern of paying for products/services, there's more confidence behind the attempt to sell
them a more expensive product/service.

@samueljlieber samueljlieber force-pushed the 17.0-subscriptions-update-upsell-ksc branch from b6814f4 to c03be73 Compare December 28, 2023 21:48
@samueljlieber
Copy link
Contributor

@StraubCreative this PR is good to go 👍

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants