[FIX] getting_started: invalid addon-path and useless lambda #6607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "../technical-training-sandbox" is added too early in the path since its still empty, and results into an "invalid addons-path" error.
The lambda function here is useless and makes newdooers think they need to use it everytime. `default=fields.Date.add(fields.Date.today(), months=3))` should do the trick, no lambda involved.
Collaborator
AntoineVDV
approved these changes
Nov 23, 2023
Collaborator
AntoineVDV
left a comment
AntoineVDV
left a comment
There was a problem hiding this comment.
@robodoo r+ rebase-ff
Collaborator
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Nov 23, 2023
The "../technical-training-sandbox" is added too early in the path since its still empty, and results into an "invalid addons-path" error. Part-of: #6607
robodoo
pushed a commit
that referenced
this pull request
Nov 23, 2023
The lambda function here is useless and makes newdooers think they need to use it everytime. `default=fields.Date.add(fields.Date.today(), months=3))` should do the trick, no lambda involved. closes #6607 Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/technical-training-sandboxbefore it becomes a valid addons folder.