[IMP] tests: make review UX and resource files #6405
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AntoineVDV
reviewed
Nov 13, 2023
Co-authored-by: Antoine Vandevenne (anv) <[email protected]>
samueljlieber
force-pushed
the
14.0-autolint-review-ux-sali
branch
from
1e71b70 to
06338b0
Compare
Contributor
Author
|
Thanks for your review and suggestions @AntoineVDV 🙂 I implemented them in 06338b0. I did end up removing |
robodoo
pushed a commit
that referenced
this pull request
Nov 13, 2023
closes #6405 Signed-off-by: Antoine Vandevenne (anv) <[email protected]> Co-authored-by: Antoine Vandevenne (anv) <[email protected]>
This was referenced Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Task: #2801043
This PR improves the user experience of using the
make reviewcommand by automatically handling whether or not the path contains the rootcontent/or not, and specifies to the user to input a relative path and not an absolute.Additionally, this PR also adds the
resource_files.pychecker into themake reviewcommand so that resource files can also be checked locally by the content team.Current behavior:
make review, if users enter a path containingcontent/, sphinxlint will try to runcontent/content/....make review, resource files are not being checked with theresource_files.pychecker .Desired behavior:
make review, if users enter a path containingcontent/, sphinxlint will try to runcontent/....make review, resource files are checked with theresource_files.pychecker .