[IMP] inventory: update delivery methods from 12 to 16 #6287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Felicious
commented
Nov 3, 2023
Contributor
Author
There was a problem hiding this comment.
Suggestions from functional support team member, @moch-odoo 😊
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
Felicious
force-pushed
the
16.0-inventory-delivery-method-feku
branch
from
7711fc9 to
d4feab9
Compare
Contributor
Author
|
HI @odoo/inventory-doc-review! Thanks in advance for reviewing this doc (: |
hojo-odoo
approved these changes
Nov 22, 2023
Contributor
hojo-odoo
left a comment
hojo-odoo
left a comment
There was a problem hiding this comment.
Hey @Felicious,
Great job on this doc. I left a few comments and suggestions for you to take a look at.
Thanks,
hojo
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
Felicious
force-pushed
the
16.0-inventory-delivery-method-feku
branch
from
e46513a to
91195f1
Compare
Contributor
Author
|
Hi @odoo/crm-doc-review ! This update about delivery methods is ready for review (: thank you in advance for this! 😄 |
StraubCreative
requested changes
Nov 23, 2023
Contributor
StraubCreative
left a comment
StraubCreative
left a comment
There was a problem hiding this comment.
Hi @Felicious
A few changes below, most notably lines 68 and 141 where the list break.
Everything else is optional 😉
Please tag me again when you're done, thanks!
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
This section does not seem complete...Is there more to this here besides changing the carrier?
Contributor
Author
There was a problem hiding this comment.
Not really, in the original doc, this section just was trying to communicate that the Carrier field on the delivery order is linked to the Carrier field on the sales order. So, changing one changes the other
content/applications/inventory_and_mrp/inventory/shipping/setup/delivery_method.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: hojo-odoo <[email protected]> Co-authored-by: Zachary Straub <[email protected]>
Felicious
force-pushed
the
16.0-inventory-delivery-method-feku
branch
from
77ffe06 to
7c58574
Compare
Contributor
Author
|
@StraubCreative Hi! This PR is ready for another review (: |
Contributor
|
LGTM, thanks @Felicious 👍 @robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 23, 2023
closes #6287 Signed-off-by: Zachary Straub (zst) <[email protected]> Co-authored-by: hojo-odoo <[email protected]> Co-authored-by: Zachary Straub <[email protected]>
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhaul Delivery methods doc (last edited 8 years ago) to align with our current documentation standards.
Summary of changes
Task