-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[ADD] Referrals: new doc explaining all of referrals #6206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
28d34bd to
cd9e30f
Compare
jero-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @larm-odoo nice work. I had some suggestions, mostly on formatting and organization. Let me know if you have any questions. Thanks
cd9e30f to
0593649
Compare
|
Thanks @jero-odoo! All comments either accepted/added to the doc or explained (not many I didn't take). I tagged you again for another look and an approval. Thanks in advance! |
jero-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @larm-odoo just a few changes (mostly grammar and spelling). Good to go otherwise 👍
0593649 to
7b9b4c3
Compare
|
Hi @tiku-odoo - this is ready for you! There is a doc link in here that links to a recruitment doc that is NOT published yet- so that error is visible, be aware. It will not appear once that is published. Also you can disregard any errors from 'code owner' per Sam. |
tiku-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job on this doc, really great flows and explanations.
I still have some more to go on this doc and I didn't want to rush through it as I've left a few functional edit suggestions above that I don't want to miss any below. Hold off on making any edits until I can finish out the doc.
Thanks and great work on this doc! Have a nice weekend
tiku-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on the document. I made a few comments and it's ready for your review.
I noticed that you didn't cover friends in this document, configuration--> Friends
I would also like to know the level of access needed to make the various edits you review in the doc (as it is mixed throughout the doc)
Looking forward to seeing this published!
|
Thank you @tiku-odoo! I incorporated your edits - thanks for finding some things I didn't catch! All set for you, @odoo/us-doc-review! Please note, the error for the document 'recruitment' is currently on #5994 - this referrals document must be published after the recruitment doc, so the link works. |
7b9b4c3 to
32abdc0
Compare
32abdc0 to
cbee644
Compare
| - :guilabel:`Contract Signed`: 50 points | ||
|
|
||
| The total points earned for a referral that is hired is 85 points. Modifications of the points | ||
| earned for each stage is done in the Recruitment application. Refer to the :doc:`../recruitment` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @larm-odoo, I am commenting on this line (552) regarding the ../recruitment build error, can you please fix this before I review?
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All fixed @samueljlieber! The link currently sends you to a doc that is being updated on #5994. So when you click it, you see this page: https://www.odoo.com/documentation/17.0/applications/hr/recruitment.html
Currently, this is mostly blank, and just has a link to the Job Positions doc. But PR #5994 is the detailed Hiring Flow doc, which is what this will be pointing to, ultimately.
cbee644 to
0ae0ade
Compare
0ae0ade to
4e469a2
Compare
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @larm-odoo! This PR looks good to me. I just pushed up a commit updating the :ref: on line 552 to point to the correct section in recruitment.rst that will be added in #5994.
@StraubCreative this PR is good to go, but needs to be merged AFTER #5994 👍
|
@samueljlieber #5994 has been merged along with it's forward-port chain, just now, on #7099 Can merge here after rebase and CI checks pass, thanks! @robodoo delegate=samueljlieber |
4e469a2 to
8ba5f1a
Compare
|
Rebased to fix CI check error, I will push up one more commit to fix a few items in the |
8ba5f1a to
09d3e39
Compare
closes #6206 Signed-off-by: Samuel Lieber (sali) <[email protected]>
New document explaining all of Referrals. Will be forward ported to 16, then 17 when that is live, and targeted edits will be made for those versions.