Skip to content

[IMP] barcode: add zebra scanner section #5827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] barcode: add zebra scanner section #5827

wants to merge 1 commit into from

Conversation

@Felicious
Copy link
Contributor

@Felicious Felicious commented Sep 12, 2023 •
edited
Loading

Summary

  • Rewrote doc to remove mentions of "you", "your", and other pronouns
  • Add setup section for Zebra scanners to resolve these barcode scanning issues
  • Note: the Zebra scanner section was tested on Odoo 16 on Sept 12 2023 (:

Task

@Felicious Felicious requested a review from a team September 12, 2023 22:58
@Felicious Felicious self-assigned this Sep 12, 2023
@robodoo
Copy link
Collaborator

robodoo commented Sep 12, 2023

Pull request status dashboard.

@C3POdoo C3POdoo requested a review from a team September 12, 2023 23:00
@Felicious
Copy link
Contributor Author

Felicious commented Sep 12, 2023

Hello @mejg-odoo and @dara-odoo! Feel free to leave comments in the Files Changed tab. Feedback on anything is welcome-- it can be about the content, wording, language, grammar, suggestions for screenshots, and etc! Ya'll are the subject matter experts 😄

(I haven't added the Honeywell mention yet, because I wasn't sure how to put it. You can let me know where in the code review!! 😉 )

You can read the fully rendered version of the documentation with this link Looking forward to your feedback 😊

@dara-odoo
Copy link

dara-odoo commented Sep 13, 2023

Hey @Felicious !

The Zebra section looks all good to me! As for the Honeywell steps, we can wait till either receive more issues about Honeywell computerized barcode scanners and/or receive a Honeywell computerized scanner to provide the steps.

Thank you for updating this!

@mejg-odoo
Copy link
Contributor

mejg-odoo commented Sep 15, 2023

Hi @Felicious !
All looks good to me as well! Pretty easily to follow and straight forward instructions. 😁
Thanks again for putting this together! 🙏

hojo-odoo
hojo-odoo reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@hojo-odoo hojo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Felicious,

I left a few comments and suggestions on this. Feel free to re-tag me for another review once you take a look.

Thanks,
hojo

@Felicious Felicious force-pushed the 16.0-barcode-zebra-scanner-feku branch 2 times, most recently from e0a2edb to 97810f2 Compare November 11, 2023 00:31
@C3POdoo C3POdoo requested a review from a team November 11, 2023 00:32
@Felicious Felicious requested a review from hojo-odoo November 11, 2023 00:35
hojo-odoo
hojo-odoo approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@hojo-odoo hojo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Felicious,

Great job on this. I just had a few minor comments. Feel free to tag it for the second round of review after you take a look.

Thanks,
hojo

Felicious
Felicious commented Nov 17, 2023
View reviewed changes
@Felicious Felicious force-pushed the 16.0-barcode-zebra-scanner-feku branch from ef16198 to f9a371a Compare November 17, 2023 01:36
@Felicious Felicious requested a review from a team November 17, 2023 01:36
@Felicious
Copy link
Contributor Author

Felicious commented Nov 17, 2023

HI @odoo/crm-doc-review! This barcode doc is ready for your second round of peer review (:

ksc-odoo
ksc-odoo approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Felicious -- this doc is GREAT! Nice job! I only had a couple SUPER-MINOR suggestions that require your attention, but once those are addressed, this one should be good to go to the next level. 👍

@Felicious Felicious force-pushed the 16.0-barcode-zebra-scanner-feku branch from e82d2f1 to 83db548 Compare November 23, 2023 01:06
@Felicious Felicious requested a review from a team November 23, 2023 01:08
StraubCreative
StraubCreative approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Felicious
Approving with comments, merge when ready or tag me again if you would like another review 👍

@robodoo delegate=Felicious

content/applications/inventory_and_mrp/barcode/setup/hardware.rst Outdated
Copy link
Contributor

@StraubCreative StraubCreative Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samueljlieber reminder to look into the :dfn: directive styling...ideally it's a tooltip or something similar 🤔

Felicious
Felicious commented Nov 23, 2023
View reviewed changes
@Felicious
[IMP] barcode: add zebra scanner section
a34b1b1 
Co-authored-by: hojo-odoo <[email protected]>
Co-authored-by: ksc-odoo <[email protected]>
Co-authored-by: Zachary Straub <[email protected]>

add more figures
@Felicious Felicious force-pushed the 16.0-barcode-zebra-scanner-feku branch from d815b17 to a34b1b1 Compare November 23, 2023 02:09
@Felicious
Copy link
Contributor Author

Felicious commented Nov 23, 2023

@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 23, 2023
@Felicious @hojo-odoo
@ksc-odoo @StraubCreative
[IMP] barcode: add zebra scanner section
56cda37 
add more figures

closes #5827

Signed-off-by: Felicia Kuan (feku) <[email protected]>
Co-authored-by: hojo-odoo <[email protected]>
Co-authored-by: ksc-odoo <[email protected]>
Co-authored-by: Zachary Straub <[email protected]>
@robodoo robodoo closed this Nov 23, 2023
This was referenced Nov 23, 2023
Closed
Closed
Closed
Closed
Closed
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented Nov 26, 2023

@Felicious this pull request has forward-port PRs awaiting action (not merged or closed):

1 similar comment
@fw-bot
Copy link
Collaborator

fw-bot commented Nov 27, 2023

@Felicious this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented Nov 28, 2023

@Felicious this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StraubCreative StraubCreative StraubCreative approved these changes

@dara-odoo dara-odoo Awaiting requested review from dara-odoo

@mejg-odoo mejg-odoo Awaiting requested review from mejg-odoo

+2 more reviewers

@ksc-odoo ksc-odoo ksc-odoo approved these changes

@hojo-odoo hojo-odoo hojo-odoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Felicious Felicious

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Felicious @robodoo @dara-odoo @mejg-odoo @fw-bot @StraubCreative @ksc-odoo @hojo-odoo