Skip to content

[ADD] Quality: Measure quality check #5760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ADD] Quality: Measure quality check #5760

wants to merge 1 commit into from

Conversation

@hojo-odoo
Copy link
Contributor

@hojo-odoo hojo-odoo commented Sep 6, 2023

This PR adds a new doc detailing how to create and process Measure quality checks.

NOTE: One of the checks is failing because the PR contains a reference to the "Quality checks" doc, which is not yet live. That doc should be live before this one, at which point the ref tags in this doc will work as intended.

@robodoo
Copy link
Collaborator

robodoo commented Sep 6, 2023

Pull request status dashboard.

@C3POdoo C3POdoo requested review from a team September 6, 2023 22:26
@hojo-odoo hojo-odoo removed request for a team September 6, 2023 22:50
Felicious
Felicious reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some prelim comments!

@StraubCreative
Copy link
Contributor

StraubCreative commented Nov 14, 2023

@odoo/us-doc-review
Need #6454 to merge first, which includes the necessary toctree updates for the CI checks to pass

@samueljlieber samueljlieber force-pushed the 16.0-quality-add-measure-quality-check-hojo branch from a30f0fb to d65f5a6 Compare November 15, 2023 16:22
@C3POdoo C3POdoo requested a review from a team November 15, 2023 16:24
@samueljlieber
Copy link
Contributor

samueljlieber commented Nov 15, 2023

Resolved merge conflict in d65f5a6

@samueljlieber samueljlieber force-pushed the 16.0-quality-add-measure-quality-check-hojo branch from d65f5a6 to 868c941 Compare November 15, 2023 16:39
@samueljlieber
Copy link
Contributor

samueljlieber commented Nov 15, 2023

Moved measure_check to the correct folder inventory_and_mrp/quality/quality_check_types/ in 868c941

@hojo-odoo hojo-odoo force-pushed the 16.0-quality-add-measure-quality-check-hojo branch from 868c941 to d396098 Compare November 15, 2023 19:39
Felicious
Felicious requested changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hojo-odoo! Great doc restructure. 😄

I just had a few suggestions about adding brief context sentences or links to related quality docs for clarification. Other than that, I just had a handful of optional wording and screenshot suggestions! Let me know when the doc is ready for another look 😊

@hojo-odoo hojo-odoo force-pushed the 16.0-quality-add-measure-quality-check-hojo branch from d396098 to 74437f9 Compare November 16, 2023 16:05
@hojo-odoo hojo-odoo requested a review from Felicious November 16, 2023 16:09
Felicious
Felicious approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc looks great to me 🥳

@hojo-odoo hojo-odoo requested a review from ksc-odoo November 16, 2023 17:54
ksc-odoo
ksc-odoo approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hojo-odoo -- great work on this doc! I have a small collection of suggestions that need your attention, but once you address those, and make the necessary adjustments, I think this one will be ready for the next stage. 👍

@hojo-odoo hojo-odoo force-pushed the 16.0-quality-add-measure-quality-check-hojo branch from 74437f9 to 3a8460a Compare November 17, 2023 21:48
@hojo-odoo hojo-odoo requested a review from a team November 17, 2023 21:54
samueljlieber
samueljlieber requested changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hojo-odoo, nice work on this PR! I have only one suggestion on using a guilabel after my technical review, please see below.

Also it looks like there is a merge conflict to be resolved.

Once this change has been made, I can move this PR forward 🙂

@hojo-odoo hojo-odoo force-pushed the 16.0-quality-add-measure-quality-check-hojo branch from 3a8460a to 81e7b7f Compare November 21, 2023 21:49
samueljlieber
samueljlieber approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @hojo-odoo, thanks 😊

On to you @StraubCreative!

StraubCreative
StraubCreative approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ty all 👍
Note @hojo-odoo we'll have to edit sections + screenshots that reference Tablet View, starting at saas-16.4 branch onwards.

@robodoo r+

content/applications/inventory_and_mrp/quality/quality_check_types/measure_check.rst
specified, a *Measure* quality check is created for that specific work order, rather than the
manufacturing order as a whole.

*Measure* quality checks created for work orders must be processed from the tablet view. To do so,
Copy link
Contributor

@StraubCreative StraubCreative Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to adjust for saas-16.4 onwards

robodoo pushed a commit that referenced this pull request Nov 22, 2023
[ADD] Quality: Measure quality check
78713f1 
closes #5760

Signed-off-by: Zachary Straub (zst) <[email protected]>
@robodoo robodoo closed this Nov 22, 2023
This was referenced Nov 22, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StraubCreative StraubCreative StraubCreative approved these changes

@Felicious Felicious Felicious approved these changes

@samueljlieber samueljlieber samueljlieber approved these changes

+1 more reviewer

@ksc-odoo ksc-odoo ksc-odoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hojo-odoo @robodoo @StraubCreative @samueljlieber @Felicious @ksc-odoo