[ADD] fleet: create new vehicles #5759

larm-odoo · 2023-09-06T19:53:18Z

Adding a new document and section to HR. No fleet documentation currently exists.

robodoo · 2023-09-06T19:54:11Z

larm-odoo · 2023-09-06T19:56:06Z

Waiting for some feedback/answers from Quentin so this doc can be finished- not ready for review yet.

larm-odoo · 2023-09-07T20:50:06Z

Hi @jcs-odoo - can you help with the codeowner issue? This is a new doc for a new app (no previous doc existed for fleet).

jcs-odoo · 2023-09-11T08:37:58Z

Hi @jcs-odoo - can you help with the codeowner issue? This is a new doc for a new app (no previous doc existed for fleet).

Hi @larm-odoo !

All good for the codeowner team

I haven't read the doc, but I saw the title "Add a vehicle". Usually, we try to avoid verbs in titles. --> https://www.odoo.com/documentation/master/contributing/documentation/content_guidelines.html#titles-and-headings

When we explain a record on a documentation page, it is not only to add a new record from scratch (like we explain in video tutorials, for example), but mostly to describe how it works in general, as a reference (which can be both to create a new record, view or edit an existing one).

I hope this is helpful. Have a good day :)

larm-odoo · 2023-09-11T15:28:18Z

Thank you @jcs-odoo - I had tagged you at the suggestion of a coworker when I got the original error, but I am glad it was a non-issue! As for the name, thank you for pointing that out, and I have updated it so it is in a better format =)

jero-odoo

Nice work @larm-odoo, only a few notes. Let me know if you have any questions. Thanks!

content/applications/hr/fleet/new_vehicle.rst

larm-odoo · 2023-09-19T14:10:14Z

Hi @tiku-odoo - this is set for the 2nd peer review!

tiku-odoo

@larm-odoo

Good start to this doc- I like the definitions you've compiled. However, I think this doc needs some intros to each section, so it isn't textbook. I've left a few comments on things to change. Notable-- it isn't the calendar module the dropdown/selector is populating. It is just a standard date selector. We should not be using the word "module." A module in Odoo is an application or set of Python instructions to be executed. All this does is select a date unless I am missing something.

Creating a company deserves a warning admonition block. This causes subscriptions to go up $$$ and potentially shut a database down if they don't resolve the upsell.

A few other questions - Are there any links with the accounting app? I see a lot of data input here.

Loop me back in for a quick review once you've made the changes. Thanks 👍
Tim

content/applications/hr/fleet.rst

content/applications/hr/fleet/new_vehicle.rst

tiku-odoo · 2023-10-06T17:01:30Z

content/applications/hr/fleet/new_vehicle.rst

+To add a new vehicle to the fleet, click the :guilabel:`Create` button, and a blank vehicle form
+will load. Enter the vehicle information in the vehicle form, then click :guilabel:`Save`.


If this document is going to be forward ported, you can use some adaptive language-- create or new --- if required save, etc. These are small edits that could save you time in the long run.

I see what you mean, but I think it's best to keep the docs for the specific versions, to keep things clear. I do the version specific changes, and I kind of like keeping everything very organized like that. I'll leave this for @StraubCreative to decide since it could go either way.

content/applications/hr/fleet/new_vehicle.rst

tiku-odoo

@larm-odoo -- Can you explain the copied info?

From #5763

content/applications/hr/fleet/new_vehicle.rst

larm-odoo · 2023-10-11T18:09:41Z

Hi @tiku-odoo - I addressed the things I could, and replied to a few things I wasn't 100% on. Thanks for the module explanation- that has been fixed. I didn't see any specific accounting documents I could link to- nothing really mentions vehicles or anything related to it. As for the duplicate looking sections- I see what you mean, but I did check the 2 docs and they are actually different forms but they have a LOT of overlapping entries. But they are accessed form different places and they do have different names for the forms and have different content. If you want to take a second look, it's ready!

tiku-odoo

Looks good Lara- still wondering about the same information in your two fleet PRs-- does one populate the other?

I think we need some clarification on whether it should populate from the model one sets up in #5763 (line 149)-- if not okay, I'm just wondering why we're instructing the user to input the same information twice.

#5763
`Model

:guilabel:Seats Number: Enter how many passengers the vehicle can accommodate.
:guilabel:Doors Number: Enter the number of doors the vehicle has.
:guilabel:Color: Enter the color of the vehicle.
:guilabel:Model Year: Enter the year the vehicle was manufactured.
:guilabel:Trailer Hitch: Check this box if the vehicle has a trailer hitch installed.
Engine

:guilabel:Fuel Type: Select the type of fuel the vehicle uses form the drop-down menu. The
options are :guilabel:Diesel, :guilabel:Gasoline, :guilabel:Hybrid Diesel, :guilabel:Hybrid Gasoline, :guilabel:Plug-in Hybrid Diesel, :guilabel:Plug-in Hybrid Gasoline,
:guilabel:CNG, :guilabel:LPG, :guilabel:Hydrogen, or :guilabel:Electric.
:guilabel:CO2 Emissions: Enter the average carbon dioxide emissions the vehicle produces in
grams per kilometer (g/km). This information is provided by the car manufacturer.
:guilabel:CO2 Standard: Enter the standard amount of carbon dioxide in grams per kilometer
(g/km) for a similar sized vehicle.
:guilabel:Transmission: Select the transmission type from the drop-down menu, either
:guilabel:Manual or :guilabel:Automatic.
:guilabel:Power: If the vehicle is electric or hybrid, enter the power the vehicle uses in
kilowatts (kW).
:guilabel:Horsepower: Enter the vehicle's horsepower in this field.
:guilabel:Horsepower Taxation: Enter the amount that is taxed based on the size of the vehicles
engine. This is determined by local taxes and regulations, and varies depending on the location.
It is recommended to check with the accounting department to ensure this value is correct.
:guilabel:Tax Deduction: This field auto-populates according to the engine specifications, and
cannot be modified. The percentage is based on the localization settings and local tax laws.`

#5759

`Model

- :guilabel:`Model Year`: Enter the year the vehicle was manufactured.
- :guilabel:`Transmission`: Select the transmission type from the drop-down menu, either
  :guilabel:`Manual` or :guilabel:`Automatic`.
- :guilabel:`Color`: Enter the color of the vehicle.
- :guilabel:`Seats Number`: Enter how many passengers the vehicle can accommodate.
- :guilabel:`Doors Number`: Enter the number of doors the vehicle has.
- :guilabel:`Trailer Hitch`: Check this box if the vehicle has a trailer hitch.

Engine

:guilabel:Horsepower: Enter the vehicle's horsepower in this field.
:guilabel:Power: If the vehicle is electric or hybrid, enter the power the vehicle uses in
kilowatts (kW).
:guilabel:Fuel Type: Select the type of fuel the vehicle uses form the drop-down menu. The
options are :guilabel:Diesel, :guilabel:Gasoline, :guilabel:Hybrid Diesel, :guilabel:Hybrid Gasoline, :guilabel:Plug-in Hybrid Diesel, :guilabel:Plug-in Hybrid Gasoline,
:guilabel:CNG, :guilabel:LPG, :guilabel:Hydrogen, or :guilabel:Electric.
:guilabel:CO2 Emissions: Enter the average carbon dioxide emissions the vehicle produces in
grams per kilometer (g/km). This information should be available from the car manufacturer, or
from the dealership the car was purchased from.
:guilabel:Co2 Standard: Enter the standard amount of carbon dioxide for a similar sized vehicle.

.. image:: new_vehicle/new-vehicle-model.png
:align: center
:alt: The new vehicle form, showing the vehicle tax section.`

content/applications/hr/fleet/new_vehicle.rst

larm-odoo · 2023-10-13T20:41:49Z

Hi @tiku-odoo and @jero-odoo:

This note has been edited so I don't lose any of this info. This doc is referencing an anchor in the configuration doc for Fleet. The PR that must be merged before this one can, is:
[ADD] fleet: new configurations doc #5763
Once that is closed, this won't have a build error since the document will be published. Once tat happens, I'll tag you both to approve this, so this can move forward.

jero-odoo

great job @larm-odoo . Had a few additional notes, let me know if you have any questions. Thanks!

content/applications/hr/fleet/new_vehicle.rst

samueljlieber

Nice job @larm-odoo! This doc looks great, I only have two small corrections that I will push up after this review, please see below. Approving now, thank you!

samueljlieber · 2023-12-29T19:53:26Z

content/applications/hr/fleet/new_vehicle.rst

Italicize app names

Suggested change

Odoo's Fleet app manages all vehicles and the accompanying documentation that comes with vehicle

Odoo's *Fleet* app manages all vehicles and the accompanying documentation that comes with vehicle

samueljlieber · 2023-12-29T20:00:36Z

content/applications/hr/fleet/new_vehicle.rst

Suggested change

XX.XX format. Repeat this for all entires needed.

XX.XX format. Repeat this for all entries needed.

Co-authored-by: jero-odoo <[email protected]>

samueljlieber · 2023-12-29T20:09:23Z

Implemented technical changes in de5d382.

@StraubCreative this PR is good to go 👍 and can be FWP all the way up to master.
Just to note, we may have a conflict on the FWP for 16.0 due to the addition of a custom anchor on new_employee.rst in this PR.

StraubCreative

@robodoo r+

robodoo · 2023-12-29T22:19:13Z

@larm-odoo @StraubCreative staging failed: ci/runbot on 876654e39181f2931dfa2dbc4daf346138c5508c (view more at https://runbot.odoo.com/runbot/build/55789433)

StraubCreative · 2023-12-29T23:23:40Z

@robodoo retry

closes #5759 Signed-off-by: Zachary Straub (zst) <[email protected]> Co-authored-by: jero-odoo <[email protected]>

fw-bot · 2024-01-02T05:54:40Z

@larm-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

fw-bot · 2024-01-03T05:54:31Z

@larm-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

[FW][ADD] fleet: create new vehicles #7221

C3POdoo requested review from a team September 6, 2023 19:54

larm-odoo marked this pull request as draft September 6, 2023 20:01

larm-odoo force-pushed the 15.0-fleet-add-new-vehicle-larm branch 2 times, most recently from 34cde92 to d22f586 Compare September 7, 2023 20:44

larm-odoo marked this pull request as ready for review September 7, 2023 20:45

larm-odoo force-pushed the 15.0-fleet-add-new-vehicle-larm branch from d22f586 to 6eb4cf4 Compare September 11, 2023 15:24

C3POdoo requested a review from a team September 11, 2023 15:25

jero-odoo requested changes Sep 14, 2023

View reviewed changes

content/applications/hr/fleet/new_vehicle.rst Outdated Show resolved Hide resolved

content/applications/hr/fleet/new_vehicle.rst Outdated Show resolved Hide resolved

content/applications/hr/fleet/new_vehicle.rst Outdated Show resolved Hide resolved

larm-odoo force-pushed the 15.0-fleet-add-new-vehicle-larm branch from 6eb4cf4 to 3efb319 Compare September 18, 2023 21:03

larm-odoo requested a review from a team September 19, 2023 14:09

larm-odoo requested review from tiku-odoo and removed request for a team September 19, 2023 14:10

tiku-odoo reviewed Oct 6, 2023

View reviewed changes

tiku-odoo mentioned this pull request Oct 6, 2023

[ADD] fleet: new configurations doc #5763

Closed

tiku-odoo reviewed Oct 6, 2023

View reviewed changes

content/applications/hr/fleet/new_vehicle.rst Show resolved Hide resolved

larm-odoo force-pushed the 15.0-fleet-add-new-vehicle-larm branch from 3efb319 to 1abb6c8 Compare October 11, 2023 18:07

Xavier-Do removed the request for review from a team October 12, 2023 07:42

tiku-odoo reviewed Oct 12, 2023

View reviewed changes

content/applications/hr/fleet/new_vehicle.rst Show resolved Hide resolved

larm-odoo force-pushed the 15.0-fleet-add-new-vehicle-larm branch from 1abb6c8 to c5b24ff Compare October 13, 2023 20:38

larm-odoo changed the title ~~[ADD] fleet: add a new vehicle~~ [ADD] fleet: create a new vehicle Dec 7, 2023

larm-odoo changed the title ~~[ADD] fleet: create a new vehicle~~ [ADD] fleet: create new vehicles Dec 7, 2023

larm-odoo force-pushed the 15.0-fleet-add-new-vehicle-larm branch from c5b24ff to 2fb4a8c Compare December 7, 2023 16:05

larm-odoo requested a review from jero-odoo December 7, 2023 20:46

jero-odoo approved these changes Dec 11, 2023

View reviewed changes

larm-odoo force-pushed the 15.0-fleet-add-new-vehicle-larm branch from f9f77fe to 2dd2e28 Compare December 11, 2023 17:38

larm-odoo force-pushed the 15.0-fleet-add-new-vehicle-larm branch from 2dd2e28 to 75d0422 Compare December 29, 2023 19:30

C3POdoo requested a review from a team December 29, 2023 19:32

larm-odoo requested a review from samueljlieber December 29, 2023 19:33

samueljlieber approved these changes Dec 29, 2023

View reviewed changes

[ADD] fleet: add a new vehicle

de5d382

Co-authored-by: jero-odoo <[email protected]>

samueljlieber force-pushed the 15.0-fleet-add-new-vehicle-larm branch from 75d0422 to de5d382 Compare December 29, 2023 20:05

StraubCreative approved these changes Dec 29, 2023

View reviewed changes

robodoo pushed a commit that referenced this pull request Dec 29, 2023

[ADD] fleet: add a new vehicle

e3d4c2f

closes #5759 Signed-off-by: Zachary Straub (zst) <[email protected]> Co-authored-by: jero-odoo <[email protected]>

robodoo temporarily deployed to merge December 30, 2023 00:42 Inactive

robodoo closed this Dec 30, 2023

This was referenced Dec 30, 2023

[FW][ADD] fleet: create new vehicles #7204

Closed

[FW][ADD] fleet: create new vehicles #7205

Closed

		To add a new vehicle to the fleet, click the :guilabel:`Create` button, and a blank vehicle form
		will load. Enter the vehicle information in the vehicle form, then click :guilabel:`Save`.

	Odoo's Fleet app manages all vehicles and the accompanying documentation that comes with vehicle
	Odoo's Fleet app manages all vehicles and the accompanying documentation that comes with vehicle

	XX.XX format. Repeat this for all entires needed.
	XX.XX format. Repeat this for all entries needed.

[ADD] fleet: create new vehicles #5759

[ADD] fleet: create new vehicles #5759

Uh oh!

Conversation

larm-odoo commented Sep 6, 2023

Uh oh!

robodoo commented Sep 6, 2023

Uh oh!

larm-odoo commented Sep 6, 2023

Uh oh!

larm-odoo commented Sep 7, 2023

Uh oh!

jcs-odoo commented Sep 11, 2023

Uh oh!

larm-odoo commented Sep 11, 2023

Uh oh!

jero-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

larm-odoo commented Sep 19, 2023

Uh oh!

tiku-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tiku-odoo Oct 6, 2023

Choose a reason for hiding this comment

Uh oh!

larm-odoo Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tiku-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

larm-odoo commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tiku-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

larm-odoo commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jero-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samueljlieber left a comment

Choose a reason for hiding this comment

Uh oh!

samueljlieber Dec 29, 2023

Choose a reason for hiding this comment

Uh oh!

samueljlieber Dec 29, 2023

Choose a reason for hiding this comment

Uh oh!

samueljlieber commented Dec 29, 2023

Uh oh!

StraubCreative left a comment

Choose a reason for hiding this comment

tiku-odoo left a comment •

edited

Loading

larm-odoo commented Oct 11, 2023 •

edited

Loading

larm-odoo commented Oct 13, 2023 •

edited

Loading